From 8fa361dffa1b153dec1b905eb8345763c5d896d5 Mon Sep 17 00:00:00 2001 From: philsmd Date: Tue, 14 Feb 2017 18:22:46 +0100 Subject: [PATCH] dead code: already implied length within the android fde parsing function --- src/interface.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/interface.c b/src/interface.c index beacdd9cb..293800a23 100644 --- a/src/interface.c +++ b/src/interface.c @@ -7868,7 +7868,8 @@ int androidfde_parse_hash (u8 *input_buf, u32 input_len, hash_t *hash_buf, MAYBE u32 data_len = input_len - 1 - 3 - 1 - saltlen_len - 1 - saltbuf_len - 1 - keylen_len - 1 - keybuf_len - 1; - if (data_len != 3072) return (PARSER_SALT_LENGTH); + // the following check is not needed, since we already checked all the other lengths (sub strings) + // if (data_len != 3072) return (PARSER_SALT_LENGTH); /** * copy data