arno/hashcat
1
0
Fork 0
mirror of https://github.com/hashcat/hashcat.git synced 2025-06-15 20:48:47 +00:00
Code Issues Releases Wiki Activity

tainted string: maybe strdup () helps us out

Browse Source
This commit is contained in:
philsmd 2017-02-15 13:57:07 +01:00
parent add3ec6f54
commit 0ca0448bd9
No known key found for this signature in database
GPG Key ID: 4F25D016D9D6A8AF
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/shared.c
View File

@ -256,6 +256,10 @@ void setup_environment_variables ()
if (compute) if (compute)
{ {
// fix for coverity "TAINTED_STRING" issue (using the environment variable directly could be "dangerous")
compute = strdup (compute);
static char display[100]; static char display[100];
u32 compute_len_max = sizeof (display); u32 compute_len_max = sizeof (display);
@ -273,6 +277,8 @@ void setup_environment_variables ()
putenv (display); putenv (display);
} }
} }
free (compute);
} }
else else
{ {