arno/hashcat
1
0
Fork 0
mirror of https://github.com/hashcat/hashcat.git synced 2024-11-22 08:08:10 +00:00
Code Issues Releases Wiki Activity

Updated handling of POCL's known bugs

Browse Source
This commit is contained in:
Gabriele Gristina 2022-01-22 22:40:18 +01:00
parent 2c0b4cd20a
commit 01a28f80f7
6 changed files with 63 additions and 76 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
docs/changes.txt
View File

@ -71,8 +71,6 @@
- Unit tests: added -r (--runtime) option
- Unit tests: handle negative status code, skip deprecated hash-types, skip hash-types with known perl modules issues, updated output
- Hash Info: show more information (Updated Hash-Format. Added Autodetect, Self-Test, Potfile and Plaintext encoding)
- Status code: updated negative status code, move -8 to -9 and set -8 as POCL warnings
- Unit tests: updated negative status code
- Backend: with kernel build options, switch from -I to -D INCLUDE_PATH, in order to support Apple Metal runtime
- Kernels: Refactored standard kernel includes in order to support Apple Metal runtime

3
docs/status_codes.txt
View File

@ -1,8 +1,7 @@
status codes on exit:
=====================
-9 = mixed backend errors (combo of -3, -4, -5, -6, -7, -8 errors type)
-8 = backend error: POCL warnings, detected space in hashcat path
-8 = mixed backend errors (combo of -3, -4, -5, -6, -7 errors type)
-7 = backend error: Invalid module_extra_buffer_size
-6 = backend error: Too many compute units to keep minimum kernel accel limit
-5 = backend error: main kernel build error

1
include/types.h
View File

@ -1690,7 +1690,6 @@ typedef struct backend_ctx
bool kernel_build_warning;
bool kernel_accel_warnings;
bool extra_size_warning;
bool pocl_warning;
bool mixed_warnings;
// generic

122
src/backend.c
View File

@ -4130,8 +4130,9 @@ void backend_ctx_destroy (hashcat_ctx_t *hashcat_ctx)
int backend_ctx_devices_init (hashcat_ctx_t *hashcat_ctx, const int comptime)
{
backend_ctx_t *backend_ctx = hashcat_ctx->backend_ctx;
user_options_t *user_options = hashcat_ctx->user_options;
const folder_config_t *folder_config = hashcat_ctx->folder_config;
backend_ctx_t *backend_ctx = hashcat_ctx->backend_ctx;
user_options_t *user_options = hashcat_ctx->user_options;
if (backend_ctx->enabled == false) return 0;
@ -5436,10 +5437,17 @@ int backend_ctx_devices_init (hashcat_ctx_t *hashcat_ctx, const int comptime)
device_param->device_local_mem_size = device_local_mem_size;
// older POCL version and older LLVM versions are known to fail compiling kernels
// we need to inform the user to update
// handling known bugs on POCL
// POCL < 1.9 doesn't like quotes in the include path, see:
// https://github.com/hashcat/hashcat/issues/2950
// https://github.com/pocl/pocl/issues/962
// POCL < 1.5 and older LLVM versions are known to fail compiling kernels
// https://github.com/hashcat/hashcat/issues/2344
// we need to inform the user to update
if (opencl_platform_vendor_id == VENDOR_ID_POCL)
{
char *pocl_version_ptr = strstr (opencl_platform_version, "pocl ");
@ -5452,15 +5460,28 @@ int backend_ctx_devices_init (hashcat_ctx_t *hashcat_ctx, const int comptime)
int pocl_maj = 0;
int pocl_min = 0;
int pocl_bug_whitespace_on_path = 0;
int pocl_bug_kernel_compiling_failure = 0;
const int res1 = sscanf (pocl_version_ptr, "pocl %d.%d", &pocl_maj, &pocl_min);
if (res1 == 2)
{
const int pocl_version = (pocl_maj * 100) + pocl_min;
if (pocl_version < 105)
if (pocl_version < 109)
{
pocl_skip = true;
if (strchr (folder_config->cpath_real, ' ') != NULL)
{
pocl_skip = true;
pocl_bug_whitespace_on_path = 1;
}
if (pocl_version < 105)
{
pocl_skip = true;
pocl_bug_kernel_compiling_failure = 1;
}
}
}
@ -5485,9 +5506,22 @@ int backend_ctx_devices_init (hashcat_ctx_t *hashcat_ctx, const int comptime)
{
event_log_error (hashcat_ctx, "* Device #%u: Outdated POCL OpenCL driver detected!", device_id + 1);
if (user_options->quiet == false) event_log_warning (hashcat_ctx, "This OpenCL driver may fail kernel compilation or produce false negatives.");
if (user_options->quiet == false) event_log_warning (hashcat_ctx, "You can use --force to override, but do not report related errors.");
if (user_options->quiet == false) event_log_warning (hashcat_ctx, NULL);
if (user_options->quiet == false)
{
if (pocl_bug_kernel_compiling_failure == 1)
{
event_log_warning (hashcat_ctx, "This OpenCL driver may fail kernel compilation or produce false negatives.");
}
if (pocl_bug_whitespace_on_path == 1)
{
event_log_warning (hashcat_ctx, "Consider moving hashcat to a path with no spaces if you want to use this POCL version.");
}
event_log_warning (hashcat_ctx, "We recommend using a version of POCL >= 1.9");
event_log_warning (hashcat_ctx, "You can use --force to override, but do not report related errors.");
event_log_warning (hashcat_ctx, NULL);
}
device_param->skipped = true;
}
@ -7331,14 +7365,12 @@ int backend_session_begin (hashcat_ctx_t *hashcat_ctx)
int backend_kernel_build_warnings = 0;
int backend_kernel_accel_warnings = 0;
int backend_extra_size_warning = 0;
int backend_pocl_warning = 0;
backend_ctx->memory_hit_warning = false;
backend_ctx->runtime_skip_warning = false;
backend_ctx->kernel_build_warning = false;
backend_ctx->kernel_accel_warnings = false;
backend_ctx->extra_size_warning = false;
backend_ctx->pocl_warning = false;
backend_ctx->mixed_warnings = false;
for (int backend_devices_idx = 0; backend_devices_idx < backend_ctx->backend_devices_cnt; backend_devices_idx++)
@ -8027,46 +8059,14 @@ int backend_session_begin (hashcat_ctx_t *hashcat_ctx)
}
else
{
if (device_param->opencl_platform_vendor_id == VENDOR_ID_POCL)
{
// POCL doesn't like quotes in the include path, see:
// https://github.com/hashcat/hashcat/issues/2950
// Maybe related:
// https://github.com/pocl/pocl/issues/962
if (strchr (folder_config->cpath_real, ' ') == NULL)
{
// untested only on windows
build_options_len += snprintf (build_options_buf + build_options_len, build_options_sz - build_options_len, "-D KERNEL_STATIC -D INCLUDE_PATH=%s ",
#if defined (_WIN) || defined (__CYGWIN__) || defined (__MSYS__)
"OpenCL");
#else
folder_config->cpath_real);
#endif
}
else
{
event_log_warning (hashcat_ctx, "Filesystem path to Hashcat contains space characters, skipping device due to POCL known bug");
event_log_warning (hashcat_ctx, "Consider moving hashcat to a path with no spaces if you want to use POCL");
event_log_warning (hashcat_ctx, NULL);
backend_pocl_warning++;
device_param->skipped_warning = true;
continue;
}
}
else
{
// tested on windows, linux, apple intel, apple silicon
// when is builded with cygwin and msys, cpath_real doesn't work
build_options_len += snprintf (build_options_buf + build_options_len, build_options_sz - build_options_len, "-D KERNEL_STATIC -D INCLUDE_PATH=\"%s\" ",
#if defined (_WIN) || defined (__CYGWIN__) || defined (__MSYS__)
"OpenCL");
#else
folder_config->cpath_real);
#endif
}
// tested on windows, linux, apple intel, apple silicon
// when is builded with cygwin and msys, cpath_real doesn't work
build_options_len += snprintf (build_options_buf + build_options_len, build_options_sz - build_options_len, "-D KERNEL_STATIC -D INCLUDE_PATH=\"%s\" ",
#if defined (_WIN) || defined (__CYGWIN__) || defined (__MSYS__)
"OpenCL");
#else
folder_config->cpath_real);
#endif
#if defined (__APPLE__)
if (is_apple_silicon() == true)
@ -11804,28 +11804,26 @@ int backend_session_begin (hashcat_ctx_t *hashcat_ctx)
int rc = 0;
backend_ctx->memory_hit_warning = (backend_memory_hit_warnings == backend_ctx->backend_devices_active);
backend_ctx->runtime_skip_warning = (backend_runtime_skip_warnings == backend_ctx->backend_devices_active);
backend_ctx->kernel_build_warning = (backend_kernel_build_warnings == backend_ctx->backend_devices_active);
backend_ctx->memory_hit_warning = (backend_memory_hit_warnings == backend_ctx->backend_devices_active);
backend_ctx->runtime_skip_warning = (backend_runtime_skip_warnings == backend_ctx->backend_devices_active);
backend_ctx->kernel_build_warning = (backend_kernel_build_warnings == backend_ctx->backend_devices_active);
backend_ctx->kernel_accel_warnings = (backend_kernel_accel_warnings == backend_ctx->backend_devices_active);
backend_ctx->extra_size_warning = (backend_extra_size_warning == backend_ctx->backend_devices_active);
backend_ctx->pocl_warning = (backend_extra_size_warning == backend_ctx->backend_devices_active);
backend_ctx->extra_size_warning = (backend_extra_size_warning == backend_ctx->backend_devices_active);
// if all active devices failed, set rc to -1
// later we prevent hashcat exit if is started in benchmark mode
if ((backend_ctx->memory_hit_warning == true) ||
(backend_ctx->runtime_skip_warning == true) ||
(backend_ctx->kernel_build_warning == true) ||
if ((backend_ctx->memory_hit_warning == true) ||
(backend_ctx->runtime_skip_warning == true) ||
(backend_ctx->kernel_build_warning == true) ||
(backend_ctx->kernel_accel_warnings == true) ||
(backend_ctx->extra_size_warning == true) ||
(backend_ctx->pocl_warning == true))
(backend_ctx->extra_size_warning == true))
{
rc = -1;
}
else
{
// handle mix of, in case of multiple devices with different warnings
backend_ctx->mixed_warnings = ((backend_memory_hit_warnings + backend_runtime_skip_warnings + backend_kernel_build_warnings + backend_kernel_accel_warnings + backend_extra_size_warning + backend_pocl_warning) == backend_ctx->backend_devices_active);
backend_ctx->mixed_warnings = ((backend_memory_hit_warnings + backend_runtime_skip_warnings + backend_kernel_build_warnings + backend_kernel_accel_warnings + backend_extra_size_warning) == backend_ctx->backend_devices_active);
if (backend_ctx->mixed_warnings) rc = -1;
}

3
src/hashcat.c
View File

@ -1753,8 +1753,7 @@ int hashcat_session_execute (hashcat_ctx_t *hashcat_ctx)
if (backend_ctx->kernel_build_warning == true) rc_final = -5;
if (backend_ctx->kernel_accel_warnings == true) rc_final = -6;
if (backend_ctx->extra_size_warning == true) rc_final = -7;
if (backend_ctx->pocl_warning == true) rc_final = -8;
if (backend_ctx->mixed_warnings == true) rc_final = -9;
if (backend_ctx->mixed_warnings == true) rc_final = -8;
}
// special case for --stdout

8
tools/test.sh
View File

@ -403,14 +403,8 @@ function status()
if [ "${RET}" -ne 0 ]; then
case ${RET} in
247)
echo "skipped by runtime (mixed backend errors detected), cmdline : ${CMD}" >> "${OUTD}/logfull.txt" 2>> "${OUTD}/logfull.txt"
e_rs=$((e_rs + 1))
;;
248)
echo "skipped by runtime (POCL warnings), cmdline : ${CMD}" >> "${OUTD}/logfull.txt" 2>> "${OUTD}/logfull.txt"
echo "skipped by runtime (mixed backend errors detected), cmdline : ${CMD}" >> "${OUTD}/logfull.txt" 2>> "${OUTD}/logfull.txt"
e_rs=$((e_rs + 1))
;;