arno/gns3-server
1
0
Fork 0
mirror of https://github.com/GNS3/gns3-server synced 2025-01-11 08:30:57 +00:00
Code Issues Releases Wiki Activity

Fixes #2108 (gns3-gui): getting project file with leading slashes issue (#1078)

Browse Source
This commit is contained in:
ziajka 2017-06-21 10:26:36 +02:00 committed by Julien Duponchelle
parent 6730cfe823
commit ea9f0e52c8
2 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gns3server/handlers/api/controller/project_handler.py
View File

@ -396,7 +396,7 @@ class ProjectHandler:
controller = Controller.instance()
project = yield from controller.get_loaded_project(request.match_info["project_id"])
path = request.match_info["path"]
path = os.path.normpath(path)
path = os.path.normpath(path).strip('/')
# Raise error if user try to escape
if path[0] == ".":

9
tests/handlers/api/controller/test_project.py
View File

@ -218,6 +218,15 @@ def test_write_file(http_controller, tmpdir, project):
assert response.status == 403
def test_write_and_get_file_with_leading_slashes_in_filename(http_controller, tmpdir, loop, project):
response = http_controller.post("/projects/{project_id}/files//hello".format(project_id=project.id), body="world", raw=True)
assert response.status == 200
response = http_controller.get("/projects/{project_id}/files//hello".format(project_id=project.id), raw=True)
assert response.status == 200
assert response.body == b"world"
def test_import(http_controller, tmpdir, controller):
with zipfile.ZipFile(str(tmpdir / "test.zip"), 'w') as myzip: