arno/gns3-server
1
0
Fork 0
mirror of https://github.com/GNS3/gns3-server synced 2024-11-24 17:28:08 +00:00
Code Issues Releases Wiki Activity

Merge branch '1.5' into 2.0

Browse Source 
Conflicts:
	gns3server/version.py
This commit is contained in:
grossmj 2016-05-29 19:52:15 -06:00
commit c1aad550fa
5 changed files with 39 additions and 41 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
gns3server/compute/project.py
View File

@ -424,6 +424,14 @@ class Project:
for file in files: for file in files:
path = os.path.join(root, file) path = os.path.join(root, file)
# Try open the file
try:
open(path).close()
except OSError as e:
msg = "Could not export file {}: {}".format(path, e)
log.warn(msg)
self.emit("log.warning", {"message": msg})
continue
# We rename the .gns3 project.gns3 to avoid the task to the client to guess the file name # We rename the .gns3 project.gns3 to avoid the task to the client to guess the file name
if file.endswith(".gns3"): if file.endswith(".gns3"):
self._export_project_file(path, z, include_images) self._export_project_file(path, z, include_images)

5
gns3server/compute/qemu/qemu_vm.py
View File

@ -28,6 +28,7 @@ import subprocess
import shlex import shlex
import asyncio import asyncio
import socket import socket
import random
import gns3server import gns3server
from gns3server.utils import parse_version from gns3server.utils import parse_version
@ -493,9 +494,9 @@ class QemuVM(BaseNode):
""" """
if not mac_address: if not mac_address:
self._mac_address = "00:00:ab:%s:%s:00" % (self.id[-4:-2], self.id[-2:]) self._mac_address = "12:34:%02x:%02x:%02x:00" % (random.randint(0, 255), random.randint(0, 255), random.randint(0, 255))
else: else:
self._mac_address = mac_address self._mac_address = mac_address[:8] + ":%02x:%02x:00" % (random.randint(0, 255), random.randint(0, 255))
log.info('QEMU VM "{name}" [{id}]: MAC address changed to {mac_addr}'.format(name=self._name, log.info('QEMU VM "{name}" [{id}]: MAC address changed to {mac_addr}'.format(name=self._name,
id=self._id, id=self._id,

54
gns3server/compute/vmware/vmware_vm.py
View File

@ -230,41 +230,28 @@ class VMwareVM(BaseNode):
if self._get_vmx_setting(connected): if self._get_vmx_setting(connected):
del self._vmx_pairs[connected] del self._vmx_pairs[connected]
# check for adapter type
if self._adapter_type != "default":
adapter_type = "ethernet{}.virtualdev".format(adapter_number)
if adapter_type in self._vmx_pairs and self._vmx_pairs[adapter_type] != self._adapter_type:
raise VMwareError("Existing VMware network adapter {} is not of type {}, please fix or set adapter type to default in GNS3".format(adapter_number,
self._adapter_type))
# # check if any vmnet interface managed by GNS3 is being used on existing VMware adapters
# if self._get_vmx_setting("ethernet{}.present".format(adapter_number), "TRUE"):
# connection_type = "ethernet{}.connectiontype".format(adapter_number)
# if connection_type in self._vmx_pairs and self._vmx_pairs[connection_type] in ("hostonly", "custom"):
# vnet = "ethernet{}.vnet".format(adapter_number)
# if vnet in self._vmx_pairs:
# vmnet = os.path.basename(self._vmx_pairs[vnet])
# #nio = self._ethernet_adapters[adapter_number].get_nio(0)
# if self.manager.is_managed_vmnet(vmnet):
# raise VMwareError("Network adapter {} is already associated with VMnet interface {} which is managed by GNS3, please remove".format(adapter_number, vmnet))
# then configure VMware network adapters # then configure VMware network adapters
self.manager.refresh_vmnet_list(ubridge=self._use_ubridge) self.manager.refresh_vmnet_list(ubridge=self._use_ubridge)
for adapter_number in range(0, self._adapters): for adapter_number in range(0, self._adapters):
# add/update the interface # add/update the interface
if self._adapter_type == "default":
# force default to e1000 because some guest OS don't detect the adapter (i.e. Windows 2012 server)
# when 'virtualdev' is not set in the VMX file.
adapter_type = "e1000"
else:
adapter_type = self._adapter_type
ethernet_adapter = {"ethernet{}.present".format(adapter_number): "TRUE", ethernet_adapter = {"ethernet{}.present".format(adapter_number): "TRUE",
"ethernet{}.addresstype".format(adapter_number): "generated", "ethernet{}.addresstype".format(adapter_number): "generated",
"ethernet{}.generatedaddressoffset".format(adapter_number): "0"} "ethernet{}.generatedaddressoffset".format(adapter_number): "0",
"ethernet{}.virtualdev".format(adapter_number): adapter_type}
self._vmx_pairs.update(ethernet_adapter) self._vmx_pairs.update(ethernet_adapter)
if self._adapter_type != "default":
self._vmx_pairs["ethernet{}.virtualdev".format(adapter_number)] = self._adapter_type
connection_type = "ethernet{}.connectiontype".format(adapter_number) connection_type = "ethernet{}.connectiontype".format(adapter_number)
if not self._use_any_adapter and connection_type in self._vmx_pairs and self._vmx_pairs[connection_type] in ("nat", "bridged", "hostonly"): if not self._use_any_adapter and connection_type in self._vmx_pairs and self._vmx_pairs[connection_type] in ("nat", "bridged", "hostonly"):
continue continue
self._vmx_pairs["ethernet{}.connectiontype".format(adapter_number)] = "custom"
self._vmx_pairs["ethernet{}.connectiontype".format(adapter_number)] = "custom"
if self._use_ubridge: if self._use_ubridge:
# make sure we have a vmnet per adapter if we use uBridge # make sure we have a vmnet per adapter if we use uBridge
allocate_vmnet = False allocate_vmnet = False
@ -273,7 +260,7 @@ class VMwareVM(BaseNode):
vnet = "ethernet{}.vnet".format(adapter_number) vnet = "ethernet{}.vnet".format(adapter_number)
if vnet in self._vmx_pairs: if vnet in self._vmx_pairs:
vmnet = os.path.basename(self._vmx_pairs[vnet]) vmnet = os.path.basename(self._vmx_pairs[vnet])
if self.manager.is_managed_vmnet(vmnet) or vmnet == "vmnet0": if self.manager.is_managed_vmnet(vmnet) or vmnet in ("vmnet0", "vmnet1", "vmnet8"):
# vmnet already managed, try to allocate a new one # vmnet already managed, try to allocate a new one
allocate_vmnet = True allocate_vmnet = True
else: else:
@ -313,6 +300,7 @@ class VMwareVM(BaseNode):
:param adapter_number: adapter number :param adapter_number: adapter number
""" """
block_host_traffic = self.manager.config.get_section_config("VMware").getboolean("block_host_traffic", False)
vnet = "ethernet{}.vnet".format(adapter_number) vnet = "ethernet{}.vnet".format(adapter_number)
if vnet not in self._vmx_pairs: if vnet not in self._vmx_pairs:
raise VMwareError("vnet {} not in VMX file".format(vnet)) raise VMwareError("vnet {} not in VMX file".format(vnet))
@ -338,10 +326,12 @@ class VMwareVM(BaseNode):
else: else:
raise VMwareError("Could not find NPF id for VMnet interface {}".format(vmnet_interface)) raise VMwareError("Could not find NPF id for VMnet interface {}".format(vmnet_interface))
# TODO: should provide that as an option if block_host_traffic:
#if source_mac: if source_mac:
# yield from self._ubridge_hypervisor.send('bridge set_pcap_filter {name} "not ether src {mac}"'.format(name=vnet, yield from self._ubridge_hypervisor.send('bridge set_pcap_filter {name} "not ether src {mac}"'.format(name=vnet,
# mac=source_mac)) mac=source_mac))
else:
log.warn("Could not block host network traffic on {} (no MAC address found)".format(vmnet_interface))
elif sys.platform.startswith("darwin"): elif sys.platform.startswith("darwin"):
yield from self._ubridge_hypervisor.send('bridge add_nio_fusion_vmnet {name} "{interface}"'.format(name=vnet, yield from self._ubridge_hypervisor.send('bridge add_nio_fusion_vmnet {name} "{interface}"'.format(name=vnet,
@ -362,7 +352,7 @@ class VMwareVM(BaseNode):
yield from self._ubridge_hypervisor.send('bridge start {name}'.format(name=vnet)) yield from self._ubridge_hypervisor.send('bridge start {name}'.format(name=vnet))
# TODO: this only work when using PCAP (NIO Ethernet) # TODO: this only work when using PCAP (NIO Ethernet): current default on Linux is NIO RAW LINUX
# source_mac = None # source_mac = None
# for interface in interfaces(): # for interface in interfaces():
# if interface["name"] == vmnet_interface: # if interface["name"] == vmnet_interface:
@ -510,17 +500,15 @@ class VMwareVM(BaseNode):
self._vmnets.clear() self._vmnets.clear()
# remove the adapters managed by GNS3 # remove the adapters managed by GNS3
for adapter_number in range(0, self._adapters): for adapter_number in range(0, self._adapters):
if self._get_vmx_setting("ethernet{}.vnet".format(adapter_number)) or \
self._get_vmx_setting("ethernet{}.connectiontype".format(adapter_number)) is None:
vnet = "ethernet{}.vnet".format(adapter_number) vnet = "ethernet{}.vnet".format(adapter_number)
if self._get_vmx_setting(vnet) or self._get_vmx_setting("ethernet{}.connectiontype".format(adapter_number)) is None:
if vnet in self._vmx_pairs: if vnet in self._vmx_pairs:
vmnet = os.path.basename(self._vmx_pairs[vnet]) vmnet = os.path.basename(self._vmx_pairs[vnet])
if not self.manager.is_managed_vmnet(vmnet): if not self.manager.is_managed_vmnet(vmnet):
continue continue
log.debug("removing adapter {}".format(adapter_number)) log.debug("removing adapter {}".format(adapter_number))
for key in list(self._vmx_pairs.keys()): self._vmx_pairs[vnet] = "vmnet1"
if key.startswith("ethernet{}.".format(adapter_number)): self._vmx_pairs["ethernet{}.connectiontype".format(adapter_number)] = "custom"
del self._vmx_pairs[key]
# re-enable any remaining network adapters # re-enable any remaining network adapters
for adapter_number in range(self._adapters, self._maximum_adapters): for adapter_number in range(self._adapters, self._maximum_adapters):

2
gns3server/handlers/api/compute/project_handler.py
View File

@ -434,7 +434,7 @@ class ProjectHandler:
if not packet: if not packet:
break break
temp.write(packet) temp.write(packet)
project.import_zip(temp, gns3vm=bool(request.GET.get("gns3vm", "1"))) project.import_zip(temp, gns3vm=bool(int(request.GET.get("gns3vm", "1"))))
except OSError as e: except OSError as e:
raise aiohttp.web.HTTPInternalServerError(text="Could not import the project: {}".format(e)) raise aiohttp.web.HTTPInternalServerError(text="Could not import the project: {}".format(e))

9
gns3server/utils/__init__.py
View File

@ -30,19 +30,20 @@ def force_unix_path(path):
return posixpath.normpath(path) return posixpath.normpath(path)
def macaddress_to_int(macaddress): def macaddress_to_int(mac_address):
""" """
Convert a macaddress with the format 00:0c:29:11:b0:0a to a int Convert a macaddress with the format 00:0c:29:11:b0:0a to a int
:param macaddress: The mac address :param mac_address: The mac address
:returns: Integer :returns: Integer
""" """
return int(macaddress.replace(":", ""), 16) return int(mac_address.replace(":", ""), 16)
def int_to_macaddress(integer): def int_to_macaddress(integer):
""" """
Convert an integer to a macaddress Convert an integer to a mac address
""" """
return ":".join(textwrap.wrap("%012x" % (integer), width=2)) return ":".join(textwrap.wrap("%012x" % (integer), width=2))