arno/gns3-server
1
0
Fork 0
mirror of https://github.com/GNS3/gns3-server synced 2024-12-25 16:28:11 +00:00
Code Issues Releases Wiki Activity

Fix minor errors reported by codacy.com

Browse Source
This commit is contained in:
Julien Duponchelle 2015-11-03 12:34:22 +01:00
parent a961387af9
commit bd54c55ae1
5 changed files with 7 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gns3server/modules/port_manager.py
View File

@ -91,7 +91,7 @@ class PortManager:
return self._console_port_range return self._console_port_range
@console_host.setter @console_port_range.setter
def console_port_range(self, new_range): def console_port_range(self, new_range):
assert isinstance(new_range, tuple) assert isinstance(new_range, tuple)
@ -112,7 +112,7 @@ class PortManager:
return self._udp_port_range return self._udp_port_range
@udp_host.setter @udp_port_range.setter
def udp_port_range(self, new_range): def udp_port_range(self, new_range):
assert isinstance(new_range, tuple) assert isinstance(new_range, tuple)

1
gns3server/web/logger.py
View File

@ -94,7 +94,6 @@ class WinStreamHandler(logging.StreamHandler):
stream.write(msg.encode(stream.encoding, errors="replace").decode(stream.encoding)) stream.write(msg.encode(stream.encoding, errors="replace").decode(stream.encoding))
stream.write(self.terminator) stream.write(self.terminator)
self.flush() self.flush()
pass
except Exception: except Exception:
self.handleError(record) self.handleError(record)

2
tests/conftest.py
View File

@ -73,7 +73,7 @@ def _get_unused_port():
return port return port
@pytest.fixture(scope="session") @pytest.fixture
def server(request, loop, port_manager, monkeypatch): def server(request, loop, port_manager, monkeypatch):
"""A GNS3 server""" """A GNS3 server"""

8
tests/handlers/test_upload.py
View File

@ -144,10 +144,10 @@ def test_backup_images(server, tmpdir, loop):
tar.close() tar.close()
assert os.path.exists(os.path.join('QEMU', 'a.img')) assert os.path.exists(os.path.join('QEMU', 'a.img'))
open(os.path.join('QEMU', 'a.img')).read() == 'hello' assert open(os.path.join('QEMU', 'a.img')).read() == 'hello'
assert os.path.exists(os.path.join('QEMU', 'b.img')) assert os.path.exists(os.path.join('QEMU', 'b.img'))
open(os.path.join('QEMU', 'b.img')).read() == 'world' assert open(os.path.join('QEMU', 'b.img')).read() == 'world'
def test_backup_projects(server, tmpdir, loop): def test_backup_projects(server, tmpdir, loop):
@ -176,7 +176,7 @@ def test_backup_projects(server, tmpdir, loop):
tar.close() tar.close()
assert os.path.exists(os.path.join('a', 'a.gns3')) assert os.path.exists(os.path.join('a', 'a.gns3'))
open(os.path.join('a', 'a.gns3')).read() == 'hello' assert open(os.path.join('a', 'a.gns3')).read() == 'hello'
assert os.path.exists(os.path.join('b', 'b.gns3')) assert os.path.exists(os.path.join('b', 'b.gns3'))
open(os.path.join('b', 'b.gns3')).read() == 'world' assert open(os.path.join('b', 'b.gns3')).read() == 'world'

9
tests/modules/vpcs/test_vpcs_vm.py
View File

@ -171,15 +171,6 @@ def test_update_startup_script(vm):
assert f.read() == content assert f.read() == content
def test_update_startup_script(vm):
content = "echo GNS3 VPCS\nip 192.168.1.2\n"
vm.startup_script = content
filepath = os.path.join(vm.working_dir, 'startup.vpc')
assert os.path.exists(filepath)
with open(filepath) as f:
assert f.read() == content
def test_update_startup_script_h(vm): def test_update_startup_script_h(vm):
content = "setname %h\n" content = "setname %h\n"
vm.name = "pc1" vm.name = "pc1"