arno/gns3-server
1
0
Fork 0
mirror of https://github.com/GNS3/gns3-server synced 2024-12-02 21:28:10 +00:00
Code Issues Releases Wiki Activity

Detect invalid environment variable and send a warning when creating a Docker node. Ref #2683

Browse Source
This commit is contained in:
grossmj 2019-02-19 17:34:10 +07:00
parent ae3515434c
commit aea4ae808f
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
gns3server/compute/docker/docker_vm.py
View File

@ -347,6 +347,9 @@ class DockerVM(BaseNode):
if self._environment: if self._environment:
for e in self._environment.strip().split("\n"): for e in self._environment.strip().split("\n"):
e = e.strip() e = e.strip()
if e.split("=")[0] == "":
self.project.emit("log.warning", {"message": "{} has invalid environment variable: {}".format(self.name, e)})
continue
if not e.startswith("GNS3_"): if not e.startswith("GNS3_"):
formatted = self._format_env(variables, e) formatted = self._format_env(variables, e)
params["Env"].append(formatted) params["Env"].append(formatted)