arno/gns3-server
1
0
Fork 0
mirror of https://github.com/GNS3/gns3-server synced 2024-11-28 11:18:11 +00:00
Code Issues Releases Wiki Activity

Remove running VBoxManage as another user option (root for instance). See #248.

Browse Source
This commit is contained in:
Jeremy 2015-07-03 14:37:07 -06:00
parent 65953847f6
commit 8e652778f9
1 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
gns3server/modules/virtualbox/__init__.py
View File

@ -95,13 +95,7 @@ class VirtualBox(BaseManager):
command_string = " ".join(command) command_string = " ".join(command)
log.info("Executing VBoxManage with command: {}".format(command_string)) log.info("Executing VBoxManage with command: {}".format(command_string))
try: try:
vbox_user = self.config.get_section_config("VirtualBox").get("vbox_user") process = yield from asyncio.create_subprocess_exec(*command, stdout=asyncio.subprocess.PIPE, stderr=asyncio.subprocess.PIPE)
if vbox_user:
# TODO: test & review this part
sudo_command = "sudo -i -u {} ".format(vbox_user) + " ".join(command)
process = yield from asyncio.create_subprocess_shell(sudo_command, stdout=asyncio.subprocess.PIPE, stderr=asyncio.subprocess.PIPE)
else:
process = yield from asyncio.create_subprocess_exec(*command, stdout=asyncio.subprocess.PIPE, stderr=asyncio.subprocess.PIPE)
except (OSError, subprocess.SubprocessError) as e: except (OSError, subprocess.SubprocessError) as e:
raise VirtualBoxError("Could not execute VBoxManage: {}".format(e)) raise VirtualBoxError("Could not execute VBoxManage: {}".format(e))