Support /static/ files serving, Ref: #1362

gns3server/handlers/index_handler.py

@@ -14,12 +14,15 @@
 # You should have received a copy of the GNU General Public License
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
+import os
+import aiohttp
 
 from gns3server.web.route import Route
 from gns3server.controller import Controller
 from gns3server.compute.port_manager import PortManager
 from gns3server.compute.project_manager import ProjectManager
 from gns3server.version import __version__
+from gns3server.utils.static import get_static_path
 
 
 class IndexHandler:
@@ -64,6 +67,29 @@ class IndexHandler:
         response.template("project.html",
                           project=controller.get_project(request.match_info["project_id"]))
 
+    @Route.get(
+        r"/static/{filename:.+}",
+        parameters={
+            "filename": "Static filename"
+        },
+        status_codes={
+            200: "Static file returned",
+            404: "Static cannot be found",
+        },
+        raw=True,
+        description="Get static resource")
+    def static(request, response):
+        filename = request.match_info["filename"]
+        filename = os.path.normpath(filename).strip("/")
+
+        # Raise error if user try to escape
+        if filename[0] == ".":
+            raise aiohttp.web.HTTPForbidden()
+
+        static = get_static_path(filename)
+
+        yield from response.file(static)
+
     @Route.get(
         r"/v1/version",
         description="Old 1.0 API"

gns3server/utils/static.py

@@ -0,0 +1,29 @@
+#!/usr/bin/env python
+#
+# Copyright (C) 2018 GNS3 Technologies Inc.
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+import os
+
+
+def get_static_path(filename):
+    """
+    Returns full static path for given filename
+    :param filename: relative filename
+    :return: absolute path
+    """
+    current_dir = os.path.dirname(os.path.abspath(__file__))
+    static_directory = os.path.abspath(os.path.join(current_dir, '..', 'static'))
+    return os.path.join(static_directory, filename)

gns3server/web/response.py

@@ -117,6 +117,9 @@ class Response(aiohttp.web.Response):
         """
         Return a file as a response
         """
+        if not os.path.exists(path):
+            raise aiohttp.web.HTTPNotFound()
+
         ct, encoding = mimetypes.guess_type(path)
         if not ct:
             ct = 'application/octet-stream'

scripts/update-bundled-web-ui.sh

@@ -0,0 +1,11 @@
+#!/usr/bin/env bash
+
+rm gns3server/appliances/*
+rmdir gns3server/appliances
+rm -Rf /tmp/gns3-registry
+
+git clone https://github.com/GNS3/gns3-registry.git /tmp/gns3-registry
+mv /tmp/gns3-registry/appliances gns3server/appliances
+
+git add .
+git commit -m "Sync appliances"

tests/handlers/test_index.py

@@ -15,13 +15,12 @@
 # You should have received a copy of the GNU General Public License
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
-
-import aiohttp
 import os
-from unittest.mock import patch
+
 
 from gns3server.version import __version__
 from gns3server.controller import Controller
+from gns3server.utils.static import get_static_path
 
 
 def test_index(http_root):
@@ -50,6 +49,20 @@ def test_project(http_root, async_run):
     assert response.status == 200
 
 
+def test_static(http_root, tmpdir):
+    tmpfile = get_static_path('testing.txt')
+    with open(tmpfile, 'w+') as f:
+        f.write('world')
+    response = http_root.get('/static/testing.txt')
+    assert response.status == 200
+    os.remove(tmpfile)
+
+
+def test_static_not_found(http_root, tmpdir):
+    response = http_root.get('/static/not-found.txt')
+    assert response.status == 404
+
+
 def test_v1(http_root):
     """
     The old api v1 raise a 429

tests/utils/test_path.py

@@ -21,7 +21,6 @@ import aiohttp
 
 
 from gns3server.utils.path import check_path_allowed, get_default_project_directory
-from gns3server.utils import force_unix_path
 
 
 def test_check_path_allowed(config, tmpdir):

tests/utils/test_static.py

@@ -0,0 +1,22 @@
+#!/usr/bin/env python
+#
+# Copyright (C) 2018 GNS3 Technologies Inc.
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+from gns3server.utils.static import get_static_path
+
+
+def test_get_static_path():
+    assert get_static_path('test').endswith('gns3server/static/test')

tests/web/test_response.py

@@ -0,0 +1,44 @@
+# -*- coding: utf-8 -*-
+#
+# Copyright (C) 2018 GNS3 Technologies Inc.
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+import pytest
+
+from unittest.mock import MagicMock
+from aiohttp.web import HTTPNotFound
+
+from gns3server.web.response import Response
+
+
+@pytest.fixture()
+def response():
+    request = MagicMock()
+    return Response(request=request)
+
+
+def test_response_file(async_run, tmpdir, response):
+    filename = str(tmpdir / 'hello')
+    with open(filename, 'w+') as f:
+        f.write('world')
+
+    async_run(response.file(filename))
+    assert response.status == 200
+
+
+def test_response_file_not_found(async_run, tmpdir, response):
+    filename = str(tmpdir / 'hello-not-found')
+
+    pytest.raises(HTTPNotFound, lambda: async_run(response.file(filename)))