From 5459543eb52d70c7f2bafed73fa3cba5656869de Mon Sep 17 00:00:00 2001 From: grossmj Date: Wed, 4 Jan 2023 18:21:17 +0800 Subject: [PATCH] Fix issue when detecting Dynamips version (version is not set until after Dynamips has started) --- gns3server/compute/dynamips/hypervisor.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/gns3server/compute/dynamips/hypervisor.py b/gns3server/compute/dynamips/hypervisor.py index c23a44f2..03e21933 100644 --- a/gns3server/compute/dynamips/hypervisor.py +++ b/gns3server/compute/dynamips/hypervisor.py @@ -24,7 +24,6 @@ import os import subprocess import asyncio -from gns3server.utils import parse_version from gns3server.utils.asyncio import wait_for_process_termination from .dynamips_hypervisor import DynamipsHypervisor from .dynamips_error import DynamipsError @@ -205,7 +204,7 @@ class Hypervisor(DynamipsHypervisor): command = [self._path] command.extend(["-N1"]) # use instance IDs for filenames command.extend(["-l", "dynamips_i{}_log.txt".format(self._id)]) # log file - if not sys.platform.startswith("win") and parse_version(self.version) >= parse_version('0.2.23'): + if not sys.platform.startswith("win"): command.extend(["-H", "{}:{}".format(self._host, self._port), "--console-binding-addr", self._console_host]) else: command.extend(["-H", str(self._port)])