arno/gns3-server
1
0
Fork 0
mirror of https://github.com/GNS3/gns3-server synced 2025-01-13 01:20:58 +00:00
Code Issues Releases Wiki Activity

Require "Project.Audit" permission to duplicate a project and check if "Project.Allocate" permission for the destination.

Browse Source
This commit is contained in:
grossmj 2024-12-06 14:09:08 +10:00
parent bbff6974e6
commit 4e41aefbdb
No known key found for this signature in database
GPG Key ID: 0A2D76AC45EA25CD
2 changed files with 21 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
gns3server/api/routes/controller/projects.py
View File

@ -426,26 +426,42 @@ async def import_project(
status_code=status.HTTP_201_CREATED, status_code=status.HTTP_201_CREATED,
response_model=schemas.Project, response_model=schemas.Project,
responses={**responses, 409: {"model": schemas.ErrorMessage, "description": "Could not duplicate project"}}, responses={**responses, 409: {"model": schemas.ErrorMessage, "description": "Could not duplicate project"}},
dependencies=[Depends(has_privilege("Project.Allocate"))] dependencies=[Depends(has_privilege("Project.Audit"))]
) )
async def duplicate_project( async def duplicate_project(
project_data: schemas.ProjectDuplicate, project_data: schemas.ProjectDuplicate,
project: Project = Depends(dep_project), project: Project = Depends(dep_project),
current_user: schemas.User = Depends(get_current_active_user),
rbac_repo: RbacRepository = Depends(get_repository(RbacRepository)),
pools_repo: ResourcePoolsRepository = Depends(get_repository(ResourcePoolsRepository)) pools_repo: ResourcePoolsRepository = Depends(get_repository(ResourcePoolsRepository))
) -> schemas.Project: ) -> schemas.Project:
""" """
Duplicate a project. Duplicate a project.
Required privilege: Project.Allocate Required privilege: Project.Audit
""" """
pool_memberships = await pools_repo.get_resource_memberships(project.id)
# check if the project can be duplicated somewhere (either in a pool or in the root)
if not current_user.is_superadmin:
can_be_duplicated_somewhere = False
if pool_memberships:
for pool in pool_memberships:
if await rbac_repo.check_user_has_privilege(current_user.user_id, f"/pools/{pool.resource_pool_id}", "Project.Allocate"):
can_be_duplicated_somewhere = True
break
if not can_be_duplicated_somewhere and not await rbac_repo.check_user_has_privilege(current_user.user_id, "/projects", "Project.Allocate"):
log.warning(f"Project {project.name} cannot be duplicated anywhere")
raise HTTPException(status_code=status.HTTP_403_FORBIDDEN)
reset_mac_addresses = project_data.reset_mac_addresses reset_mac_addresses = project_data.reset_mac_addresses
new_project = await project.duplicate( new_project = await project.duplicate(
name=project_data.name, reset_mac_addresses=reset_mac_addresses name=project_data.name, reset_mac_addresses=reset_mac_addresses
) )
# Add the new project in the same resource pools if the duplicated project is in any # Add the new project in the same resource pools if the duplicated project belongs to any
pool_memberships = await pools_repo.get_resource_memberships(project.id)
if pool_memberships: if pool_memberships:
resource_create = schemas.ResourceCreate(resource_id=new_project.id, resource_type="project", name=new_project.name) resource_create = schemas.ResourceCreate(resource_id=new_project.id, resource_type="project", name=new_project.name)
resource = await pools_repo.create_resource(resource_create) resource = await pools_repo.create_resource(resource_create)

2
gns3server/db/repositories/pools.py
View File

@ -80,7 +80,7 @@ class ResourcePoolsRepository(BaseRepository):
await self._db_session.commit() await self._db_session.commit()
return result.rowcount > 0 return result.rowcount > 0
async def get_resource_memberships(self, resource_id: UUID) -> List[models.UserGroup]: async def get_resource_memberships(self, resource_id: UUID) -> List[models.ResourcePool]:
""" """
Get all resource memberships in resource pools. Get all resource memberships in resource pools.
""" """