1
0
mirror of https://github.com/GNS3/gns3-server synced 2025-02-26 07:02:12 +00:00

Apply feedback from @grossmj

This commit is contained in:
Julien Duponchelle 2017-07-05 16:36:39 +02:00
parent 08423eff96
commit 4097bab565
No known key found for this signature in database
GPG Key ID: CE8B29639E07F5E8
3 changed files with 4 additions and 4 deletions

View File

@ -602,11 +602,11 @@ class BaseNode:
""" """
yield from self._ubridge_send('bridge reset_packet_filters ' + bridge_name) yield from self._ubridge_send('bridge reset_packet_filters ' + bridge_name)
i = 0 i = 0
for (type, values) in filters.items(): for (filter_type, values) in filters.items():
cmd = "bridge add_packet_filter {bridge_name} {filter_name} {filter_type} {filter_value}".format( cmd = "bridge add_packet_filter {bridge_name} {filter_name} {filter_type} {filter_value}".format(
bridge_name=bridge_name, bridge_name=bridge_name,
filter_name="filter" + str(i), filter_name="filter" + str(i),
filter_type=type, filter_type=filter_type,
filter_value=" ".join([str(v) for v in values])) filter_value=" ".join([str(v) for v in values]))
yield from self._ubridge_send(cmd) yield from self._ubridge_send(cmd)
i += 1 i += 1

View File

@ -381,7 +381,7 @@ class VPCSVM(BaseNode):
if self.ubridge: if self.ubridge:
yield from self._add_ubridge_udp_connection("VPCS-{}".format(self._id), self._local_udp_tunnel[1], nio) yield from self._add_ubridge_udp_connection("VPCS-{}".format(self._id), self._local_udp_tunnel[1], nio)
elif self.is_running(): elif self.is_running():
raise VPCSError("Sorry, adding a link to a started VPCS instance is not supported without using uBridge.") raise VPCSError("Sorry, updating a link to a started VPCS instance is not supported without using uBridge.")
self._ethernet_adapter.add_nio(port_number, nio) self._ethernet_adapter.add_nio(port_number, nio)
log.info('VPCS "{name}" [{id}]: {nio} added to port {port_number}'.format(name=self._name, log.info('VPCS "{name}" [{id}]: {nio} added to port {port_number}'.format(name=self._name,

View File

@ -75,7 +75,7 @@ FILTERS = [
{ {
"type": "corrupt", "type": "corrupt",
"name": "Corrupt", "name": "Corrupt",
"description": "The percentage represents the chance for a packet to be corrupt", "description": "The percentage represents the chance for a packet to be corrupted",
"parameters": [ "parameters": [
{ {
"name": "Frequency", "name": "Frequency",