arno/etesync-server
1
0
Fork 0
mirror of https://github.com/etesync/server synced 2024-11-22 08:48:07 +00:00
Code Issues Releases Wiki Activity

fix(etebase_fastapi): fix crash on shutdown (#133)

Browse Source 
self.redis isn't None, it's actually unset, so accessing it results
in an exception:

```
ERROR:    Traceback (most recent call last):
  File "./.venv/lib/python3.9/site-packages/starlette/routing.py", line 624, in lifespan
    await receive()
  File "./.venv/lib/python3.9/site-packages/starlette/routing.py", line 521, in __aexit__
    await self._router.shutdown()
  File "./.venv/lib/python3.9/site-packages/starlette/routing.py", line 608, in shutdown
    await handler()
  File "./etebase_fastapi/main.py", line 72, in on_shutdown
    await redisw.close()
  File "./etebase_fastapi/redis.py", line 18, in close
    if self.redis is not None:
AttributeError: 'RedisWrapper' object has no attribute 'redis'
```
This commit is contained in:
Xiretza 2022-05-07 19:37:53 +02:00 committed by GitHub
parent 76efbb6cb9
commit b620d0a39c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
etebase_fastapi/redis.py
View File

@ -15,7 +15,7 @@ class RedisWrapper:
self.redis = await aioredis.create_redis_pool(self.redis_uri) self.redis = await aioredis.create_redis_pool(self.redis_uri)
async def close(self): async def close(self):
if self.redis is not None: if hasattr(self, "redis"):
self.redis.close() self.redis.close()
await self.redis.wait_closed() await self.redis.wait_closed()