arno/etesync-server
1
0
Fork 0
mirror of https://github.com/etesync/server synced 2024-12-26 17:28:08 +00:00
Code Issues Releases Wiki Activity

Login/Changepassword: change to verifying the hostname without the part.

Browse Source 
Verifying the port was causing issues, and anyhow, this check is
paranoid and isn't strictly necessary for security.
The problem is that Django's `get_host()` and the equivalent on some
platforms returns it without the port, though on others (like e.g. the
library we use from JS) it returns with the port. This was inconsistent
and was causing authentication to fail.

We thus relaxed the test to not include the port when matching, which
should make it work consistently across all platforms.
This commit is contained in:
Tom Hacohen 2020-11-02 10:16:04 +02:00
parent a6f5e070a4
commit 843b59a0ac
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
django_etebase/views.py
View File

@ -710,7 +710,7 @@ class AuthenticationViewSet(viewsets.ViewSet):
elif challenge_data['userId'] != user.id:
content = {'code': 'wrong_user', 'detail': 'This challenge is for the wrong user'}
return Response(content, status=status.HTTP_400_BAD_REQUEST)
elif not settings.DEBUG and host != request.get_host():
elif not settings.DEBUG and host.split(':', 1)[0] != request.get_host():
detail = 'Found wrong host name. Got: "{}" expected: "{}"'.format(host, request.get_host())
content = {'code': 'wrong_host', 'detail': detail}
return Response(content, status=status.HTTP_400_BAD_REQUEST)