1
0
mirror of https://github.com/etesync/server synced 2024-12-29 10:48:07 +00:00

Revert "Add a django middleware to cleanup db connections."

This ended up being useless because of the way startlette and fastapi do
thread pools. The middleware is called in one thread, the path in
another, and the dependency in yet another.

This reverts commit 473448246f.
This commit is contained in:
Tom Hacohen 2020-12-30 15:37:59 +02:00
parent 6738c2cf20
commit 6ec03c3d34
2 changed files with 0 additions and 17 deletions

View File

@ -5,7 +5,6 @@ from fastapi import FastAPI, Request
from fastapi.middleware.cors import CORSMiddleware from fastapi.middleware.cors import CORSMiddleware
from fastapi.middleware.trustedhost import TrustedHostMiddleware from fastapi.middleware.trustedhost import TrustedHostMiddleware
from .middleware import DjangoDbConnectionCleanupMiddleware
from .exceptions import CustomHttpException from .exceptions import CustomHttpException
from .msgpack import MsgpackResponse from .msgpack import MsgpackResponse
from .routers.authentication import authentication_router from .routers.authentication import authentication_router
@ -43,7 +42,6 @@ def create_application(prefix="", middlewares=[]):
app.include_router(test_reset_view_router, prefix=f"{BASE_PATH}/test/authentication") app.include_router(test_reset_view_router, prefix=f"{BASE_PATH}/test/authentication")
app.add_middleware(DjangoDbConnectionCleanupMiddleware)
app.add_middleware( app.add_middleware(
CORSMiddleware, CORSMiddleware,
allow_origin_regex="https?://.*", allow_origin_regex="https?://.*",

View File

@ -1,15 +0,0 @@
from starlette.types import ASGIApp, Receive, Scope, Send
from django.db import close_old_connections, reset_queries
class DjangoDbConnectionCleanupMiddleware:
def __init__(self, app: ASGIApp):
self.app = app
async def __call__(self, scope: Scope, receive: Receive, send: Send):
reset_queries()
close_old_connections()
try:
await self.app(scope, receive, send)
finally:
close_old_connections()