arno/etesync-server
1
0
Fork 0
mirror of https://github.com/etesync/server synced 2024-11-22 16:58:08 +00:00
Code Issues Releases Wiki Activity

Remove port from host_from_request check

Browse Source 
This strips the port from the client requests, comparing only the hostnames or IP addresses, and should alleviate nonstandard port and initial testing issues.  Tested on Linux, Mac, and Android clients.  Closes #105.

Code is from this comment:

https://github.com/etesync/server/issues/66#issuecomment-731215345
This commit is contained in:
James 2021-09-19 14:21:33 -04:00 committed by Tom Hacohen
parent d11504093c
commit 453869d71d
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
etebase_fastapi/routers/authentication.py
View File

@ -161,7 +161,7 @@ def validate_login_request(
raise HttpError("challenge_expired", "Login challenge has expired") raise HttpError("challenge_expired", "Login challenge has expired")
elif challenge_data["userId"] != user.id: elif challenge_data["userId"] != user.id:
raise HttpError("wrong_user", "This challenge is for the wrong user") raise HttpError("wrong_user", "This challenge is for the wrong user")
elif not settings.DEBUG and validated_data.host.split(":", 1)[0] != host_from_request: elif not settings.DEBUG and validated_data.host.split(":", 1)[0] != host_from_request.split(":", 1)[0]:
raise HttpError( raise HttpError(
"wrong_host", f'Found wrong host name. Got: "{validated_data.host}" expected: "{host_from_request}"' "wrong_host", f'Found wrong host name. Got: "{validated_data.host}" expected: "{host_from_request}"'
) )