739 Commits (ee11b82fe52efc5be9434fcdf99c1cf86f833df4)

Author	SHA1	Message	Date
Tom Hacohen	eb95eada91	Import: Add an alias for our addressbook and davdroid account types.	7 years ago
Tom Hacohen	861d5e4b4e	Fix account type and authority to use function and not string.	7 years ago
Tom Hacohen	26c0a62dc4	Don't crash when immediately entering collection after creation.	7 years ago
Tom Hacohen	674ea1eeca	Workaround Android account creation issue (ignoring userData) ... It seems like there's an issue with Android that sometimes the userData passed to addAccountExplicitly is not correctly set in the Android cache making it return null on subsequent fetches. It doesn't always happen because some cases clear the cache, however I can consistently trigger it by creating and deleting an account a few times in a row.	7 years ago
Tom Hacohen	db82757bc4	Show an error message when failing to create an account.	7 years ago
Tom Hacohen	aeae7de077	Workaround: ignore invalid account errors when syncing contacts ... This is an ugly workaround. For some reason a sync is called when an account is removed. Since the main account is removed, we get an invalid account exception when trying to fetch it. Need to find out why a sync is even triggered and just remove it there.	7 years ago
Tom Hacohen	c81ba0cddb	Create an AndroidCompat class to wrap around Android oddities. ... As part of it, move removeAccount to that class.	7 years ago
Tom Hacohen	de6a124bf2	Remove unnecessary InvalidAccountException ... Based on commit d4e386441091ae3a84382f2088dfad03ea80c666 from DAVdroid.	7 years ago
Tom Hacohen	068e0c6b4d	Expose appName from App and use it.	7 years ago
Ricki Hirner	51840c3a22	Fix some inconsistencies	7 years ago
Ricki Hirner	138d344a5b	Open DAVdroid main activity when add a "DAVdroid Address book" account is added over Settings	7 years ago
Tom Hacohen	d6ace869fe	Remove add, share and delete restrictions on address books ... Now that we have multiple address books support, we can share and delete address books like we did calendars.	7 years ago
Tom Hacohen	2f95ddbda2	Import: Fix address book import. ... The import code assumed there can be only one address book, and that it's the main one. This commit fixes that wrong assumption.	7 years ago
Tom Hacohen	e729bcff42	ViewCollection: fix addressbook stats.	7 years ago
Tom Hacohen	51aecba9a0	LocalAddressBook: Add a way to get address book by UID.	7 years ago
Tom Hacohen	19b955f981	Change LocalAddressBook to look like LocalCalendar (accept journalentity)	7 years ago
Tom Hacohen	48a77530a8	Make account type strings non-translateable.	7 years ago
Tom Hacohen	dfb8981752	Remove the ACCOUNT_TYPE constant (now a string resource) ... This corresponds to commit 41dae8bcb3335b9e77d9e73b33e9bb14f8900af9 from DAVdroid, but was done manually.	7 years ago
Ricki Hirner	0d7e2362b3	Improve address book details in debug info	7 years ago
Ricki Hirner	310b94e280	Add more debug information ... * power saving status * permissions * address book accounts	7 years ago
Tom Hacohen	1422d95ccf	Disallow user removal of address book accounts ... We don't want users to remove address books on their own, we want to control these automatically. This commit blocks it.	7 years ago
Tom Hacohen	83ef63e94b	Remove getCollections and add the afterLoad workaround to getJournals.	7 years ago
Tom Hacohen	589f81c50d	Add multiple address books support ... Android allows only having one address book per account, so until now users of EteSync were only able to have one address book. This was always an annoying limitation, but even more so now that journal sharing is implemented. Luckily, DAVdroid recently implemented multiple account support by creating sub-accounts for address books. This patch is an import of the DAVdroid changes, with adjustments to work with EteSync, and a few changes that did not make sense for EteSync. The original commits' split didn't provide any value over this squash, and the amount of adjustments and addition needed to be done to apply them, made me decide to squash this change together. This commit is mostly based on: dfec72ce6b8ff5e0780e9ac4418c81d080f4b60b 9817594da14ad8dffae18de386e14aeaf41312b9	7 years ago
Tom Hacohen	2e25c44d78	Journalmanager crypto: Make AsymmetricKeyPair serializable. ... This should fix a rare crash on the login page.	7 years ago
Tom Hacohen	71d694c1c1	Fingerprint: Change the fingerprint format to be numeric instead of hex. ... Thanks to @dschuermann for the suggestion. This makes it easier for people of non-latin speaking cultures to compare the fingerprints. Code is based off of Signal's fingerprint generation.	7 years ago
Tom Hacohen	be108389c5	Journal viewer: verify journal entry content is not null before searching it. ... This actually happened for a user, which is weird, because entries should never be null, but I guess it is a possible scenario.	7 years ago
Tom Hacohen	96443a0b57	Journal model: fix broken database migration ... Add missing readOnly column Make the new_Entry foreign key refer to new_Journal and not the old one.	7 years ago
Tom Hacohen	fab8aa90ac	Collection owner: Handle the case of owner == null.	7 years ago
Tom Hacohen	201e4e09eb	Update to the new jorunal entries API.	7 years ago
Tom Hacohen	148260110a	Journal members: update according to the new members API.	7 years ago
Tom Hacohen	53e7ba98ab	Debug activity: Remove references to jbworkaround (we don't need it).	7 years ago
Tom Hacohen	1ab32be0f6	Add support for read-only journals. ... This change only works for calendars at the moment, because we don't have shared address books anyway. This is currently only implemented in the client, and only as a read-only attribute, you can't make a journal read-only yet. This requires server support that is not yet there, but it's better to be ready for this sooner rather than later.	7 years ago
Tom Hacohen	df3db6b357	LocalCalendar: accept JournalEntity, not CollectionInfo when creating and updating. ... Some of the information is now saved there, and more will be transferred soon. CollectionInfo includes the encrypted part, and journalentity the non-encrypted part of the journal info, so both are needed.	8 years ago
Tom Hacohen	f8d0878003	Journal sharing: Add a nice error message when journal is not found.	8 years ago
Tom Hacohen	5c2601f408	Fingerprint verification: dismiss dialog when not trusting fingerprint.	8 years ago
Tom Hacohen	3c1cad8960	Fingerprint: Improve how the fingerprint dialog looks like.	8 years ago
Tom Hacohen	fc52194d39	Journalmanager: rename CRUD method to be more consistent. ... All are now on of: list, delete, create and update.	8 years ago
Tom Hacohen	0bade21aae	ViewCollection: list the journal's owner if it's not owned by us.	8 years ago
Tom Hacohen	348e24c3e3	Account: indicate on the list if a collection is shared.	8 years ago
Tom Hacohen	eeda46338d	Disallow sharing of journals with version < 2. ... The reason for that is that before version 2, all the journals of a particular user shared the same encryption key, which means, sharing a journal of version one, would essentially give away the encryption key of all of its journals, even the private ones. This is thus blocked for security reasons.	8 years ago
Tom Hacohen	4c47384198	Journals: support adding back deleted journals. ... This currently just adds the journal back, but doesn't re-apply the journal, so the calendar for example would be empty, but the journal itself would be listed and visible.	8 years ago
Tom Hacohen	d3057f86f0	Disallow sharing of address books. ... At the moment we only support one address book per user, and sharing address books will interfere with this model. Hopefully, we'll add multiple address book support in the next release, and then we'll re-enable this.	8 years ago
Tom Hacohen	93fb1e3c54	Remove redundant dbhelper calls. ... These calls were made obsolete after the switch to requery. We no longer need to get the database, because we no longer use it.	8 years ago
Tom Hacohen	e15a26af9c	User info: fix version detection, and don't verify on fetch. ... We were not detecting the version correctly, but always just assumed latest version, which is obviously wrong. In addition, before this commit we used to automatically verify on fetch, which wasn't flexible enough for some use cases. This fixes that too.	8 years ago
Tom Hacohen	9fb9db9327	ViewCollection: only allow owner to edit collections.	8 years ago
Tom Hacohen	656dad3615	Add UI to add/remove/list journal members. ... Only owners of a journal are allowed to control and view its members.	8 years ago
Tom Hacohen	4246ae7ede	Add a way to view own fingerprint. ... This adds a menu option from the account page to view your own keypair (to compare when sharing).	8 years ago
Tom Hacohen	4c6176a6f4	Fetch userinfo on account creation. ... We need the keypair to access shared journals, so we need to make sure to fetch it at the moment we create the local account, which is what this commit does.	8 years ago
Tom Hacohen	a57936982d	Add a fragment to setup user info. ... This is used to create a keypair and put it on the server if one doesn't exist, and fetch it and save it locally if one does. It's currently called from the account activity.	8 years ago
Tom Hacohen	beccb33904	Journal: use journal keys if available. ... If a journal has a key set to it (usually used for shared journals), use it instead of the symmetric key. The key of the journal is asymmetrically encrypted using our keypair.	8 years ago
Tom Hacohen	43803b6d3e	AccountSettings: Add a keypair setting. ... This is used for storing the asymmetric key pair.	8 years ago
Tom Hacohen	ae08510729	Requery: Fix database to have the correct constraints (on upgrade). ... Requery doesn't automatically update column constraints, and there was an issue with it applying indexes before adding the new columns which was also causing troubles. This commit, while ugly, just manually updates the database using raw SQL to what we expect it to be.	8 years ago
Tom Hacohen	e2f206e02e	Services: Move to a requery model instead of raw SQL and improve models. ... Having it in raw sql was slowing down development, and was error-prone. It's much cleaner now, easier to handle, and enables us to develop faster. In this change I also fixed the fetching of journals to be by service and id, not just id, because just id is not guaranteed to be unique.	8 years ago
Tom Hacohen	8b79529a94	Bump version.	8 years ago
Tom Hacohen	88ceeaa2a5	Entry and journal: fix uniqueness to be composited, and not just by uid. ... Before this change, uid was unique on its own, this was wrong, because due to shared journals, we can have the same journal in two accounts, and we can thus have both journal and entry UIDs more than once. This fixes the constraint to be unique for journal, uid, and service, uid combinations. This is currently disabled for journals because of a bug in requery.	8 years ago
Tom Hacohen	a4a32045e8	Journal: get and persist owner and key. ... The server was changed so the owner of the journal, and the encrypted key (if a shared journal) would be exposed. This change fetches it, and saves it.	8 years ago
Tom Hacohen	efe832ddb4	Journalmanager: Add api for the members endpoint. ... This API controls the members of a journal, that is, access control.	8 years ago
Tom Hacohen	11e37dbd1e	Journalmanager: add API to interact with the UserInfo ... This is where the keypair is stored on the server. Both the public facing public key, and the encrypted private key	8 years ago
Tom Hacohen	e836b4c716	Crypto: Add basic asymmetric encryption methods	8 years ago
Tom Hacohen	89731519e9	Account view: cleanup and share collection list items and adapter. ... They were redundant and needed some cleanup, now they are better, and shared between calendar and contact.	8 years ago
Ricki Hirner	17d90a4569	Allow null values for IS_ORGANIZER	8 years ago
Tom Hacohen	e82d8affe8	Update okhttp and submodules to latest.	8 years ago
Tom Hacohen	30af730048	requery: update to 1.3.0. ... Although this release is claimed to fix the afterLoad issue, this is not the case. We are just updating it so the upgrade path later one would be easier.	8 years ago
Tom Hacohen	190ec89c2c	JournalModel: don't convert to list when getting collections. ... Just use the iterator we get back already.	8 years ago
Tom Hacohen	da87d14ae9	Journalmanager: always use the api error message when available.	8 years ago
Tom Hacohen	6579ac8cf1	View/EditCollection: Add icons to menu operations	8 years ago
Tom Hacohen	8f1f4785a6	Revert "Update requery and remove the afterLoad workaround." ... Unfortunately this requery version introduced a regression. When adding a new account, it takes syncign a few times until it works. It looks like requery is not loading the recently saved instances. This reverts commit f0f70ff1c61996d0e45d8f72d24654c739c325f7.	8 years ago
Tom Hacohen	57f447d372	Requery: Don't destroy and recreate db when updating.	8 years ago
Tom Hacohen	d80cce9aad	CryptoManager: add an HMAC_SIZE (in bytes) constant.	8 years ago
Tom Hacohen	56996b98c4	Update requery and remove the afterLoad workaround. ... Prior to this version of requery there was an issue that prevented afterLoad to be called in some cases. This issue forced us to add an explicit call to afterLoad. It's now fixed, so the workaround is no longer required. Reference issue: https://github.com/requery/requery/issues/487	8 years ago
Tom Hacohen	c95aaaf5fd	HintManager: simplify by moving to strings and removing the need to register	8 years ago
Tom Hacohen	c42602d030	Contacts/Event: Set PRODID to EteSync.	8 years ago
Tom Hacohen	4e0cd7f554	SyncManager: Use the last journal id as the ctag, instead of storing it. ... We were storing the ctag separately although the data was already present in the journal. The last entry's ID is always the CTAG. This could cause issues if sync is aborted exactly at the right time. I managed to trigger this issue on rare cases.	8 years ago
Tom Hacohen	338dd5e075	Database: Mark collections class as deprecated. ... It's only used for migrations, and has been considered deprecated for a while. Mark it as deprecated to make it extra obvious that this should not be used.	8 years ago
Tom Hacohen	fcbf26a03b	Tests: Add journalentrymanager tests.	8 years ago
Tom Hacohen	14e6f757c5	Journalmanager: Change getUuid to getUid (the rest says uid too).	8 years ago
Tom Hacohen	7cefb64db2	CollectionInfo: rename url -> uid.	8 years ago
Tom Hacohen	2e7ac65883	Tests: Add some basic tests.	8 years ago
Tom Hacohen	dd425ecbe2	HttpUrl: Add a way to create from string host and auth token.	8 years ago
Tom Hacohen	d41b7827ee	Tests: Move constants to a shared file.	8 years ago
Tom Hacohen	9ba0f39660	Tests: Add basic authenticator tests.	8 years ago
Tom Hacohen	94f2682195	Tests: add basic encryption tests.	8 years ago
Tom Hacohen	a77e49c033	Tests: remove useless HttpClient test.	8 years ago
Tom Hacohen	70b549033c	Crypto: add an exception to when crypto version is too new.	8 years ago
Tom Hacohen	5abf635fa0	Base64: Pull in the base64 impl from the android source code. ... It seems like this is the only (semi) sane way to get base64 to work on both Android and local tests.	8 years ago
Tom Hacohen	e3c48a0560	ImportFragment: move to the import package.	8 years ago
Tom Hacohen	ea91063178	Use the safe getDrawable function instead of the version specific one.	8 years ago
Tom Hacohen	52723dac67	View collection: add a showcase to explain how to import.	8 years ago
Tom Hacohen	51d9c75c56	AccountActivity: Add a showcase to the account activity.	8 years ago
Tom Hacohen	cb140a3387	Main activity: Add a showcase for adding an account. ... Turn it off by default if upgrading to this version, because this means the user most likely already knows how to add an account.	8 years ago
Tom Hacohen	f650d38435	Hints manager: Add a class to manage hints (show once info) ... This is much cleaner than what was there before, and enables to easily add more hints.	8 years ago
Tom Hacohen	2570c9671d	Bump version	8 years ago
Tom Hacohen	4dd11a1912	Update minsdk version to 4.1 (16). ... Prior to this version, the list of available crypto was quite poor.	8 years ago
Tom Hacohen	80fad58de4	Fix build break.	8 years ago
Ricki Hirner	c83b28c3bb	Account settings: restart loader after sync interval update ... * debug info: add signature	8 years ago
Tom Hacohen	4920bc0c81	SSLSocketFactory: Update the cipher priority list to something more secure. ... We can assume much safer ciphers since we control the server too and we don't have to work with old insecure servers.	8 years ago
Ricki Hirner	3a0c112fad	Enable SSL_RSA_WITH_3DES_EDE_CBC_SHA for all Android versions ... * refactor cipher selection	8 years ago
Tom Hacohen	c2e7914290	CollectionInfo: remove the obsolete support VEVENT and support VTODO.	8 years ago
Tom Hacohen	0a4d4a9d9e	Calendar sync adapter service: minor cleanup.	8 years ago
Ricki Hirner	1295e4557e	AccountsActivity: show message when global sync is disabled	8 years ago
Ricki Hirner	433484626f	Don't use uid2445 column on Android <4.2; alarm ACTION: compare only value (ignore parameters)	8 years ago
Ricki Hirner	f1ea00d816	Improve Android 7 workaround behavior in combination with CATEGORIES/VCard4 contact groups	8 years ago
Ricki Hirner	be833b03ee	Retain Events.UID_2445 when preparing events for upload ... * move file name/UID generation from SyncManager to LocalContact, LocalEvent, LocalTask * rename updateFileNameAndUID() to prepareForUpload() * use random UUID for contacts, UidGenerator with Android device ID for events/tasks * LocalEvent.prepareForUpload(): use existing UID_2445 if available	8 years ago
Ricki Hirner	97aefad0a2	Android 7 workaround: update hash after group membership operations	8 years ago
Tom Hacohen	d6558da503	Bump version.	8 years ago
Tom Hacohen	9486719cbb	Import: Resolved account name and icon when possible. ... We assume the name of the account == package name, which is the best guess we have. Android doesn't have a way to get account name/icon at the moment.	8 years ago
Tal Hacohen	e4fc23eb70	Journal - Load entries on background	8 years ago
Tal Hacohen	2706021a5e	Import - Add account type to calendar account list	8 years ago
Tal Hacohen	bee502a440	Sort contacts accounts by name and type	8 years ago
Tom Hacohen	1227a66409	Import: Make icon acessible and get it for address book.	8 years ago
Tom Hacohen	15580374fa	Import: Make the select calendar/account lists nicer ... This also adds an icon (that will soon be replaced with the icon of the relevant account), and shares the design between the calendar and the contacts.	8 years ago
Tom Hacohen	7915a51f1f	Import: Make account import activity prettier.	8 years ago
Tom Hacohen	0d848f0573	Merge: Add import from local accounts ... This set of commits add import from local accounts. It's a bit rough around the edges, but it's good enough to go in, so work can continue collaboratively.	8 years ago
Tal Hacohen	9684123f68	Use App.log instead of Log in import fragmnets	8 years ago
Tal Hacohen	6820d9d413	Change desgin of both import lists	8 years ago
Tal Hacohen	8d208b3438	Refactor calendar account to import package	8 years ago
Tal Hacohen	1e9e055924	Import - Use ResultFragment in all import framgnets	8 years ago
Tal Hacohen	56aba7c669	Extract ResultFragment from ImportFragment	8 years ago
Tal Hacohen	a7c5ccadc9	Import - Change toolbar title according to relevant fragment	8 years ago
Tal Hacohen	1629ffba9f	Import - Add fragment to import all contacts from account	8 years ago
Tal Hacohen	7cac473c74	Import - Split ImportActivity to fragments and activity	8 years ago
Tal Hacohen	33a310344b	Import - Add all events to selected calendar	8 years ago
Tal Hacohen	594c401038	Import - Show calendars in expandable list view	8 years ago
Tal Hacohen	466870ff50	Import - Add basic import activity	8 years ago
Tal Hacohen	2261d6e385	Import calendar: Add calendar account class. ... CalendarAccount loads all different accounts and their calendar lists.	8 years ago
Tom Hacohen	1482fb01cb	JournalManager: make jorunal version read-only.	8 years ago
Tom Hacohen	cd5e5487a8	JournalManager: make IntegrityException inherit from GeneralSecurityException.	8 years ago
Tom Hacohen	cf805d4e72	JournalManager: add version info to Journals and use it in crypto ... The crypto class now behaves differently depending on the version of the journal. The current difference is in the key derivation, and that the new version of the crypto also hmacs the version automatically whenever it hmacs anything. The versioning was added for better future-proofing of the code. The derivation change was done because before we were creating the same password for all of the journals, now we do it per-journal. This means that we can, if needed in the future use this password as the journal password when sharing journals without compromising the security of the rest of the journals.	8 years ago
Tom Hacohen	7357447786	Collectioninfo: fix typo in ToString field exclusion.	8 years ago
Tom Hacohen	c3e30138dd	Syncmanager: get a collection info for all sync managers.	8 years ago
Tom Hacohen	01add874dc	Remove unneeded fixme.	8 years ago
Tom Hacohen	d2eaf5f434	Use the new CryptoManager instead of the main encryption password. ... This will give us more flexibility in the future because now the encryption key and derivation is all managed in one place.	8 years ago
Tom Hacohen	4004eca762	Syncmanager: use the journalId as the unique collection id.	8 years ago
Tom Hacohen	1e6fc5a9cb	Crypto: rename Cipher to CryptoManager.	8 years ago
Tom Hacohen	abd13d4d3d	Crypto: refactor the Cipher class. ... Include the hmac in the cipher class. Derive keys on class creation instead of on encrypt/decrypt.	8 years ago
Tom Hacohen	0fbee1ea02	JournalManager: rename Helpers to Crypto. ... These are crypto helpers, this should have been named this way from the start.	8 years ago
Tom Hacohen	225d01c143	Crypto: Only create random generator as needed.	8 years ago
Tom Hacohen	de834915be	Bump version.	8 years ago
Tom Hacohen	1d87de2e7a	App update: set the app version on first launch if not already set. ... The app update broadcast receiver is only called on the first update, not install, which was causing EteSync to think it was updating from version 1 on the first update, doesn't matter which version one was updating from. This fixes it by saving the version on the first run.	8 years ago
Tom Hacohen	784070c27c	SyncManager: add remote entries to cache only after they've been processed ... Before this change we were adding them to cache before they were processed, potentially persisting malformed entries, or entries we haven't yet processed causing issues if sync was aborted before an entry was fully processed.	8 years ago
Tom Hacohen	987076d95e	Webview: fix behaviour of toolbar back button and simplify.	8 years ago
Tom Hacohen	3a83cf8303	Collection deletion: mark as deleted in cache, but don't actually delete. ... This is important for protecting against potential data loss.	8 years ago
Tom Hacohen	ba9f217d66	Webview: also open tos and about from within the app.	8 years ago
Tom Hacohen	9ba84109b2	Login: add a "forgot password" link.	8 years ago
Tom Hacohen	d21a498925	Webview: improve whitelist, and include all of the "accounts/" subpath.	8 years ago
Tom Hacohen	e7694924b4	Automatically fix non-dirty entries with null etag on upgrade ... Commit 5d1c90dcba fixed a bug where entries added from the server were marked as "local only" (null etag) which was causing issues. That commit fixes it for newly added resources, but existing resources remained broken. This commit goes through the database and fixes all of the existing broken resources. It skips dirty entries because figuring out if they were just created or updated is complex, and the chances of doing an update at exactly the same time there are dirty entries is quite low, so the complexity involved is just not worth it.	8 years ago
Tom Hacohen	7562a7a76b	ViewCollection: use the new LocalCalendar.findByName to get calendar.	8 years ago
Tom Hacohen	19ceab96b0	Bump version.	8 years ago
Tom Hacohen	5d1c90dcba	Resource: set eTag when creating a new one from server. ... Before this commit we would create new entries from the server without an etag, essentially marking them as "local only". While the actual value of the eTag is not currently used, null or not matters. Because the resources were "local only", we would get weird behaviours like having an "ADD" action when changing a resource.	8 years ago
Tom Hacohen	84244330b7	Always log deletes, even when not previously added to server. ... Before this change we would only add "deletes" to the server when the resource has been previously uploaded. This means that if a resource has been created and then deleted before a sync, it would not be saved, which is essentially data-loss. This commit fixes it, so we always upload a delete entry.	8 years ago