1
0
mirror of https://github.com/etesync/android synced 2024-11-18 14:18:05 +00:00
Commit Graph

433 Commits

Author SHA1 Message Date
Tom Hacohen
5db8545f8f Upgrade ical4android. 2020-01-09 12:54:22 +02:00
Tom Hacohen
72253932d3 Revert "Revert "Revert "App: only init the data store once per application."""
Even more reverts. :(
After additional testing (based on user reports) it seems like this may
still be causing issues. I find it weird and don't understand why, but
I'm reverting this as a precaution so people aren't affected.

Related to #97

This reverts commit da3ac48bbf.
2019-12-17 10:08:40 +02:00
Tom Hacohen
496b6cd633 Fix tests. 2019-11-28 18:51:10 +02:00
Tom Hacohen
63cbaddfc6 Add a lock when pushing changes.
This is not needed for proper deployments where the server properly locks
the database tables. But in some older etesync server versions and possibly
bad databases, this is not the case.
OpenTasks causes EteSync to concurrently try to sync, so this at least makes
sure this race condition doesn't happen for these rare cases.
2019-11-26 12:47:48 +02:00
Tom Hacohen
5fc26c6461 Fix issue with journal preview showing the wrong dates. 2019-11-21 18:56:40 +02:00
Tom Hacohen
da3ac48bbf Revert "Revert "App: only init the data store once per application.""
A lot of reverts. :)

According to more information and testing in #97, this was indeed
unrelated and 1.9.3 was enough to fix it.

This reverts commit 73179318f3.
2019-11-18 13:43:36 +02:00
Tom Hacohen
e860a37bf7 Update the user guide's url to the Android specific one. 2019-11-14 18:22:52 +02:00
Tom Hacohen
73179318f3 Revert "App: only init the data store once per application."
It seems like this is the cause of #97 as 19b4e2a796
hasn't fixed the issue. Still not sure why it's happening, but reverting
it so no more users suffer from this issue.

This reverts commit 26ea8900a2.
2019-11-11 19:37:10 +02:00
Tom Hacohen
19b4e2a796 Revert "Add a reentrant lock to our entity data store."
I'm pretty sure this was causing the recent issues with tasks and events
disappearing as described in #97.

Regardless of this, it's not actually needed as SQLite on Android is
already thread-safe. The SQLite locks some users were experiencing were
probably fixed in 26ea8900a2

This reverts commit 9ed172e23c.
2019-11-04 14:01:32 +02:00
Ricki Hirner
8422892708 Address books accounts: set initial user data twice for older Android versions 2019-11-04 10:16:42 +02:00
Tom Hacohen
26ea8900a2 App: only init the data store once per application.
We were accidentally initialising it once every time we were
trying to access it.
2019-10-16 14:48:22 +03:00
Tom Hacohen
9ed172e23c Add a reentrant lock to our entity data store.
Should fix issues with multiple threads trying to write to the store
at the same time.
2019-10-16 11:26:37 +03:00
Tom Hacohen
a74f188b3b requery: use our own data store class. 2019-10-16 11:15:11 +03:00
Tom Hacohen
d8600f2f04 SetupEncryption: fix issue with inserting existing services. 2019-10-16 10:36:36 +03:00
Tom Hacohen
990ab81c2b ServiceEntity: rename fetch to fetchOrCreate.
This is what it was doing anyway.
2019-10-16 10:35:53 +03:00
Tom Hacohen
9600cd3f1f Service default creation: correctly set the type.
Was a copy-paste error and it was setting type to Tasks.
2019-10-16 10:32:55 +03:00
Tom Hacohen
5df3a59a2e Gracefully handle trying to insert again an entry we have in the db. 2019-10-09 13:20:44 +03:00
Tom Hacohen
570ed1b84a SyncAdapter: move journal fetching to a separate caching class
Before this change we were fetching the journals 3 times each time (once
for each journal type).
This was wasteful both for the server and battery life. Now we just cache the
requests for a few seconds with the assumption that a burst most mean it's
the same sync operation.
2019-09-26 18:07:14 +03:00
Tom Hacohen
b50c633ca1 Improve debug information in createLocalEntry.
Print some extra information about the entry we failed to create.
2019-09-25 23:55:28 +03:00
Tom Hacohen
67b6dce44f Basemanager: consider SSLProtocolExceptions as real issues.
Kind of brings back what 1bbf00c6bd removed.
2019-09-12 00:18:05 +01:00
Tom Hacohen
c26c2c5332 Update cert4android and adjust HttpClient accordingly 2019-09-11 09:36:48 +01:00
Tom Hacohen
1bbf00c6bd Revert "BaseManager: Consider SSLHandshakeExceptions as real issues."
This change was mostly flagging non-real issues, like connection reset
by peer. Revert for now and come up with an alternative solution.

This reverts commit d3ad17e0bb.
2019-09-09 08:45:08 +01:00
Tom Hacohen
ffb7f53c0a TaskList: catch exception when trying to acquire task list 2019-08-29 14:25:52 +01:00
Tom Hacohen
d659b48f6d Create collection: gracefully handle IO exceptions. 2019-08-27 18:34:37 +01:00
Tom Hacohen
d3ad17e0bb BaseManager: Consider SSLHandshakeExceptions as real issues.
They inherit from IO exceptions so were temporarily ignored, but they could
indicate a real issue with the ability of this user to connect to the
server.
2019-08-27 18:31:11 +01:00
Tom Hacohen
36a44ba339 LocalAddressBook: update according to vcard4android changes. 2019-08-23 09:35:41 +01:00
Tom Hacohen
9560d4a65b BaseManager: add a debug log for the beginning of a network call. 2019-08-22 11:52:01 +01:00
Tom Hacohen
58f16681aa Debug info: add calling class information to reports.
This change makes it easier to detect if a debug report was actually due to a
real issue, or is just a user sending the debug activity without any real
issue behind it.

This is to battle the surprising amount of debug info spam we've had to battle
with. Essentially users sending debug info without actually experiencing any
issues and never replying to questions. This is made worse because many of
those emails also have weird addresses in CC which make it look even more
like some weird sort of spam.
2019-08-18 16:07:06 +01:00
Tom Hacohen
3c74cb1575 Optimise imports. 2019-08-18 15:26:26 +01:00
Tom Hacohen
c8a81862ea Import: fix import of contacts. 2019-08-06 14:12:50 +01:00
Tom Hacohen
9018b6cdd0 Import: make it easy to report import issues to devs. 2019-08-06 13:45:55 +01:00
Tom Hacohen
687f973725 Fix formatting. 2019-08-05 08:34:30 +01:00
Tom Hacohen
1cfdc59b17 Change journal: make it possible to revert an item to a past state.
Fixes #83
2019-07-30 20:29:47 +01:00
Tom Hacohen
6031bd2699 Events: automatically transform EMAIL event reminders to DISPLAY ones.
iCal support EMAIL event reminders which EteSync doesn't and can't support
due to end-to-end encryption. This commit therefore modifies the event reminders
DISPLAY so reminders are actually shown on the phone.

Fixes #63
2019-07-28 11:10:50 +01:00
Tom Hacohen
8e457c5ec7 Import contacts: fix wrong import account. 2019-07-21 14:48:01 +01:00
Tom Hacohen
cac34e6785 Import: verify activity is not null when finishing import.
This is really just an ugly workaround for a crash. This whole thing needs to
be redone. It's currently quite broken when it comes to lifecycle handling and
a source for many issues.
2019-07-15 13:08:06 +01:00
Tom Hacohen
84ab0cb16f Import: check if successfully acquired the provider before trying to import. 2019-07-15 13:08:06 +01:00
Tom Hacohen
1f9e7fa6a6 Revert: Import: always import, don't try to find duplicates based on UID
This is somehow a revert of 536bef9815.

It was initially implemented as a workaround for #24, but having
improved all the clients to deal with weird UIDs and matured a lot since
then, I believe this is no longer an issue.

Would have to keep a close eye for regressions.
2019-07-06 10:38:28 +01:00
Tom Hacohen
bbd40e0255 LocalGroup: implement updateAsDirty. 2019-07-06 10:28:42 +01:00
Tom Hacohen
cc83e2c5d9 Tasks: implement update as dirty. 2019-07-06 10:03:18 +01:00
Tom Hacohen
101e7e2559 Settings: cleanup the code to open the app's notification settings 2019-06-28 19:45:48 +01:00
Tom Hacohen
cdc5afba61 Fix debug log for failed login attempts.
Before this fix a failed loging attempt wouldn't include any debug
information on why it failed. This commit fixes that.
2019-06-26 10:51:24 +01:00
Tom Hacohen
16efe446c0 WebActivity: gracefully handle unsupported link types. 2019-06-13 10:10:23 +01:00
Tom Hacohen
7cfba6dc34 Acra: don't include email prefix.
We've recently started getting exceptions such as:
"java.lang.ClassCastException: java.lang.String cannot be cast to java.util.ArrayList"

I suspect it may be related to using the new email body prefix which is
probably not as well tested upstream as the rest of the code. Removing
it to see if this fixes things.
2019-06-13 09:57:11 +01:00
Tom Hacohen
1a7ef1b78e Sync: log broken entries on processing failure.
This change prints the content of broken entries (ones that fail parsing)
to the log so it's easier to debug issues.
2019-06-13 09:56:50 +01:00
Tom Hacohen
7932610c87 Webview: add missing call to super's save instance state. 2019-05-28 10:40:25 +01:00
Tom Hacohen
58b54f9d66 Account list: workaround rare crash when listing accounts. 2019-05-05 17:45:44 +01:00
Tom Hacohen
d358ac0ba4 Import: implement importing tasks from file.
Fixes #74.
2019-05-01 14:52:20 +01:00
Tom Hacohen
bfe68b9684 LocalTask: add a function to save tasks as dirty. 2019-05-01 14:52:16 +01:00
Tom Hacohen
f4ce548310 Import: replace size check with isEmpty(). 2019-05-01 14:31:21 +01:00