arno/etesync-android
1
0
Fork 0
mirror of https://github.com/etesync/android synced 2024-11-25 17:38:13 +00:00
Code Issues Releases Wiki Activity

Contacts sync manager: only init one resource downloader per sync.

Browse Source 
Before this we were doing it per sync entry which could be slow.
This commit is contained in:
Tom Hacohen 2019-04-04 12:53:02 +01:00
parent 487d330a7a
commit eef861614e
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
app/src/main/java/com/etesync/syncadapter/syncadapter/ContactsSyncManager.kt
View File

@ -43,6 +43,7 @@ import java.util.logging.Level
*/ */
class ContactsSyncManager @Throws(Exceptions.IntegrityException::class, Exceptions.GenericCryptoException::class, ContactsStorageException::class) class ContactsSyncManager @Throws(Exceptions.IntegrityException::class, Exceptions.GenericCryptoException::class, ContactsStorageException::class)
constructor(context: Context, account: Account, settings: AccountSettings, extras: Bundle, authority: String, private val provider: ContentProviderClient, result: SyncResult, localAddressBook: LocalAddressBook, private val remote: HttpUrl) : SyncManager<LocalAddress>(context, account, settings, extras, authority, result, localAddressBook.url, CollectionInfo.Type.ADDRESS_BOOK, localAddressBook.mainAccount.name) { constructor(context: Context, account: Account, settings: AccountSettings, extras: Bundle, authority: String, private val provider: ContentProviderClient, result: SyncResult, localAddressBook: LocalAddressBook, private val remote: HttpUrl) : SyncManager<LocalAddress>(context, account, settings, extras, authority, result, localAddressBook.url, CollectionInfo.Type.ADDRESS_BOOK, localAddressBook.mainAccount.name) {
private val resourceDownloader: ResourceDownloader
protected override val syncErrorTitle: String protected override val syncErrorTitle: String
get() = context.getString(R.string.sync_error_contacts, account.name) get() = context.getString(R.string.sync_error_contacts, account.name)
@ -51,8 +52,8 @@ constructor(context: Context, account: Account, settings: AccountSettings, extra
get() = context.getString(R.string.sync_successfully_contacts, account.name) get() = context.getString(R.string.sync_successfully_contacts, account.name)
init { init {
localCollection = localAddressBook localCollection = localAddressBook
resourceDownloader = ResourceDownloader(context)
} }
override fun notificationId(): Int { override fun notificationId(): Int {
@ -128,9 +129,8 @@ constructor(context: Context, account: Account, settings: AccountSettings, extra
@Throws(IOException::class, ContactsStorageException::class, CalendarStorageException::class) @Throws(IOException::class, ContactsStorageException::class, CalendarStorageException::class)
override fun processSyncEntry(cEntry: SyncEntry) { override fun processSyncEntry(cEntry: SyncEntry) {
val inputReader = StringReader(cEntry.content) val inputReader = StringReader(cEntry.content)
val downloader = ResourceDownloader(context)
val contacts = Contact.fromReader(inputReader, downloader) val contacts = Contact.fromReader(inputReader, resourceDownloader)
if (contacts.size == 0) { if (contacts.size == 0) {
Logger.log.warning("Received VCard without data, ignoring") Logger.log.warning("Received VCard without data, ignoring")
return return