Fix crash bug caused by leaking OnAccountsUpdateListener

app/build.gradle

@@ -72,5 +72,5 @@ dependencies {
     androidTestCompile 'com.squareup.okhttp3:mockwebserver:3.1.2'
     compile 'dnsjava:dnsjava:2.1.7'
     compile 'org.apache.commons:commons-lang3:3.4'
-    compile 'org.slf4j:slf4j-android:1.7.13'
+    compile 'org.slf4j:slf4j-android:1.7.14'
 }

app/src/main/AndroidManifest.xml

@@ -144,21 +144,6 @@
                 <action android:name="android.intent.action.MAIN"/>
             </intent-filter>
         </activity>
-        <activity
-            android:name=".ui.settings.SettingsActivity"
-            android:label="@string/settings_title">
-            <intent-filter>
-                <action android:name="android.intent.action.MANAGE_NETWORK_USAGE"/>
-
-                <category android:name="android.intent.category.DEFAULT"/>
-            </intent-filter>
-        </activity>
-        <activity
-            android:name=".ui.settings.AccountActivity"
-            android:label="@string/settings_title"
-            android:parentActivityName=".ui.settings.SettingsActivity"
-            tools:ignore="UnusedAttribute">
-        </activity>
 
         <!-- MemorizingTrustManager -->
         <activity

app/src/main/java/at/bitfire/davdroid/AccountsChangedReceiver.java

@@ -8,17 +8,38 @@
 
 package at.bitfire.davdroid;
 
+import android.accounts.Account;
+import android.accounts.AccountManager;
+import android.accounts.OnAccountsUpdateListener;
 import android.content.BroadcastReceiver;
 import android.content.Context;
 import android.content.Intent;
 
+import java.util.LinkedList;
+import java.util.List;
+
 public class AccountsChangedReceiver extends BroadcastReceiver {
 
+    protected static final List<OnAccountsUpdateListener> listeners = new LinkedList<>();
+
     @Override
     public void onReceive(Context context, Intent intent) {
         Intent serviceIntent = new Intent(context, DavService.class);
         serviceIntent.setAction(DavService.ACTION_ACCOUNTS_UPDATED);
         context.startService(serviceIntent);
+
+        for (OnAccountsUpdateListener listener : listeners)
+            listener.onAccountsUpdated(null);
+    }
+
+    public static void registerListener(OnAccountsUpdateListener listener, boolean callImmediately) {
+        listeners.add(listener);
+        if (callImmediately)
+            listener.onAccountsUpdated(null);
+    }
+
+    public static void unregisterListener(OnAccountsUpdateListener listener) {
+        listeners.remove(listener);
     }
 
 }

app/src/main/java/at/bitfire/davdroid/ui/AccountListFragment.java

@@ -35,6 +35,7 @@ import android.widget.TextView;
 import java.util.LinkedList;
 import java.util.List;
 
+import at.bitfire.davdroid.AccountsChangedReceiver;
 import at.bitfire.davdroid.Constants;
 import at.bitfire.davdroid.DavService;
 import at.bitfire.davdroid.R;
@@ -131,13 +132,12 @@ public class AccountListFragment extends ListFragment implements LoaderManager.L
 
         @Override
         protected void onStartLoading() {
-            Constants.log.debug("AccountListFragment: Start loading");
-            accountManager.addOnAccountsUpdatedListener(this, null, true);
+            AccountsChangedReceiver.registerListener(this, true);
         }
 
         @Override
         protected void onStopLoading() {
-            accountManager.removeOnAccountsUpdatedListener(this);
+            AccountsChangedReceiver.unregisterListener(this);
         }
 
         @Override