f759dd54c0
Feature's source feature string is directly stored in the database instead of having the parent pointer to simplify the database.
209 lines
6.1 KiB
Go
209 lines
6.1 KiB
Go
// Copyright 2017 clair authors
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
// Package rpm implements a featurefmt.Lister for rpm packages.
|
|
package rpm
|
|
|
|
import (
|
|
"bufio"
|
|
"fmt"
|
|
"io/ioutil"
|
|
"os"
|
|
"os/exec"
|
|
"strings"
|
|
|
|
"github.com/deckarep/golang-set"
|
|
log "github.com/sirupsen/logrus"
|
|
|
|
"github.com/coreos/clair/database"
|
|
"github.com/coreos/clair/ext/featurefmt"
|
|
"github.com/coreos/clair/ext/versionfmt"
|
|
"github.com/coreos/clair/ext/versionfmt/rpm"
|
|
"github.com/coreos/clair/pkg/commonerr"
|
|
"github.com/coreos/clair/pkg/strutil"
|
|
"github.com/coreos/clair/pkg/tarutil"
|
|
)
|
|
|
|
var ignoredPackages = []string{
|
|
"gpg-pubkey", // Ignore gpg-pubkey packages which are fake packages used to store GPG keys - they are not versionned properly.
|
|
}
|
|
|
|
type lister struct{}
|
|
|
|
func init() {
|
|
featurefmt.RegisterLister("rpm", "1.0", &lister{})
|
|
}
|
|
|
|
func isIgnored(packageName string) bool {
|
|
for _, pkg := range ignoredPackages {
|
|
if pkg == packageName {
|
|
return true
|
|
}
|
|
}
|
|
|
|
return false
|
|
}
|
|
|
|
func valid(pkg *database.Feature) bool {
|
|
return pkg.Name != "" && pkg.Version != "" &&
|
|
((pkg.SourceName == "" && pkg.SourceVersion != "") ||
|
|
(pkg.SourceName != "" && pkg.SourceVersion != ""))
|
|
}
|
|
|
|
func (l lister) ListFeatures(files tarutil.FilesMap) ([]database.Feature, error) {
|
|
f, hasFile := files["var/lib/rpm/Packages"]
|
|
if !hasFile {
|
|
return []database.Feature{}, nil
|
|
}
|
|
|
|
// Write the required "Packages" file to disk
|
|
tmpDir, err := ioutil.TempDir(os.TempDir(), "rpm")
|
|
defer os.RemoveAll(tmpDir)
|
|
if err != nil {
|
|
log.WithError(err).Error("could not create temporary folder for RPM detection")
|
|
return []database.Feature{}, commonerr.ErrFilesystem
|
|
}
|
|
|
|
err = ioutil.WriteFile(tmpDir+"/Packages", f, 0700)
|
|
if err != nil {
|
|
log.WithError(err).Error("could not create temporary file for RPM detection")
|
|
return []database.Feature{}, commonerr.ErrFilesystem
|
|
}
|
|
|
|
// Extract binary package names because RHSA refers to binary package names.
|
|
out, err := exec.Command("rpm", "--dbpath", tmpDir, "-qa", "--qf", "%{NAME} %{EPOCH}:%{VERSION}-%{RELEASE} %{SOURCERPM}\n").CombinedOutput()
|
|
if err != nil {
|
|
log.WithError(err).WithField("output", string(out)).Error("could not query RPM")
|
|
// Do not bubble up because we probably won't be able to fix it,
|
|
// the database must be corrupted
|
|
return []database.Feature{}, nil
|
|
}
|
|
|
|
packages := mapset.NewSet()
|
|
scanner := bufio.NewScanner(strings.NewReader(string(out)))
|
|
for scanner.Scan() {
|
|
line := strings.Split(scanner.Text(), " ")
|
|
if len(line) != 3 {
|
|
// We may see warnings on some RPM versions:
|
|
// "warning: Generating 12 missing index(es), please wait..."
|
|
continue
|
|
}
|
|
|
|
if isIgnored(line[0]) {
|
|
continue
|
|
}
|
|
|
|
pkg := database.Feature{Name: line[0], VersionFormat: rpm.ParserName}
|
|
pkg.Version = strings.Replace(line[1], "(none):", "", -1)
|
|
if err := versionfmt.Valid(rpm.ParserName, pkg.Version); err != nil {
|
|
log.WithError(err).WithField("version", line[1]).Warning("skipped unparseable package")
|
|
continue
|
|
}
|
|
|
|
if err := parseSourceRPM(line[2], &pkg); err != nil {
|
|
log.WithError(err).WithField("sourcerpm", line[2]).Warning("skipped unparseable package")
|
|
continue
|
|
}
|
|
|
|
if valid(&pkg) {
|
|
packages.Add(pkg)
|
|
}
|
|
}
|
|
|
|
return database.ConvertFeatureSetToFeatures(packages), nil
|
|
}
|
|
|
|
func (l lister) RequiredFilenames() []string {
|
|
return []string{"var/lib/rpm/Packages"}
|
|
}
|
|
|
|
type rpmParserState string
|
|
|
|
const (
|
|
terminate rpmParserState = "terminate"
|
|
parseRPM rpmParserState = "RPM Token"
|
|
parseArchitecture rpmParserState = "Architecture Token"
|
|
parseRelease rpmParserState = "Release Token"
|
|
parseVersion rpmParserState = "Version Token"
|
|
)
|
|
|
|
// parseSourceRPM parses the source rpm package representation string
|
|
// http://ftp.rpm.org/max-rpm/ch-rpm-file-format.html
|
|
func parseSourceRPM(sourceRPM string, pkg *database.Feature) error {
|
|
state := parseRPM
|
|
previousCheckPoint := len(sourceRPM)
|
|
release := ""
|
|
version := ""
|
|
for i := len(sourceRPM) - 1; i >= 0; i-- {
|
|
switch state {
|
|
case parseRPM:
|
|
if string(sourceRPM[i]) == "." {
|
|
state = parseArchitecture
|
|
packageType := strutil.Substring(sourceRPM, i+1, len(sourceRPM))
|
|
previousCheckPoint = i
|
|
if packageType != "rpm" {
|
|
return fmt.Errorf("unexpected package type, expect: 'rpm', got: '%s'", packageType)
|
|
}
|
|
}
|
|
case parseArchitecture:
|
|
if string(sourceRPM[i]) == "." {
|
|
state = parseRelease
|
|
architecture := strutil.Substring(sourceRPM, i+1, previousCheckPoint)
|
|
previousCheckPoint = i
|
|
if architecture != "src" && architecture != "nosrc" {
|
|
return fmt.Errorf("unexpected package architecture, expect: 'src' or 'nosrc', got: '%s'", architecture)
|
|
}
|
|
}
|
|
case parseRelease:
|
|
if string(sourceRPM[i]) == "-" {
|
|
state = parseVersion
|
|
release = strutil.Substring(sourceRPM, i+1, previousCheckPoint)
|
|
previousCheckPoint = i
|
|
if release == "" {
|
|
return fmt.Errorf("unexpected package release, expect: not empty")
|
|
}
|
|
}
|
|
case parseVersion:
|
|
if string(sourceRPM[i]) == "-" {
|
|
// terminate state
|
|
state = terminate
|
|
version = strutil.Substring(sourceRPM, i+1, previousCheckPoint)
|
|
previousCheckPoint = i
|
|
if version == "" {
|
|
return fmt.Errorf("unexpected package version, expect: not empty")
|
|
}
|
|
break
|
|
}
|
|
}
|
|
}
|
|
|
|
if state != terminate {
|
|
return fmt.Errorf("unexpected termination while parsing '%s'", state)
|
|
}
|
|
|
|
concatVersion := version + "-" + release
|
|
if err := versionfmt.Valid(rpm.ParserName, concatVersion); err != nil {
|
|
return err
|
|
}
|
|
|
|
name := strutil.Substring(sourceRPM, 0, previousCheckPoint)
|
|
if name == "" {
|
|
return fmt.Errorf("unexpected package name, expect: not empty")
|
|
}
|
|
|
|
pkg.SourceName = name
|
|
pkg.SourceVersion = concatVersion
|
|
return nil
|
|
}
|