53bf19aecf
1. Every Lister and Detector are versioned 2. detected content, are returned in a map with detector info as the key
164 lines
4.4 KiB
Go
164 lines
4.4 KiB
Go
// Copyright 2017 clair authors
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
// Package featurefmt exposes functions to dynamically register methods for
|
|
// determining the features present in an image layer.
|
|
package featurefmt
|
|
|
|
import (
|
|
"io/ioutil"
|
|
"path/filepath"
|
|
"runtime"
|
|
"sync"
|
|
"testing"
|
|
|
|
log "github.com/sirupsen/logrus"
|
|
"github.com/stretchr/testify/assert"
|
|
|
|
"github.com/coreos/clair/database"
|
|
"github.com/coreos/clair/pkg/tarutil"
|
|
)
|
|
|
|
var (
|
|
listersM sync.RWMutex
|
|
listers = make(map[string]lister)
|
|
)
|
|
|
|
// Lister represents an ability to list the features present in an image layer.
|
|
type Lister interface {
|
|
// ListFeatures produces a list of Features present in an image layer.
|
|
ListFeatures(tarutil.FilesMap) ([]database.Feature, error)
|
|
|
|
// RequiredFilenames returns the list of files required to be in the FilesMap
|
|
// provided to the ListFeatures method.
|
|
//
|
|
// Filenames must not begin with "/".
|
|
RequiredFilenames() []string
|
|
}
|
|
|
|
type lister struct {
|
|
Lister
|
|
|
|
info database.Detector
|
|
}
|
|
|
|
// RegisterLister makes a Lister available by the provided name.
|
|
//
|
|
// If called twice with the same name, the name is blank, or if the provided
|
|
// Lister is nil, this function panics.
|
|
func RegisterLister(name string, version string, l Lister) {
|
|
if name == "" || version == "" {
|
|
panic("featurefmt: could not register a Lister with an empty name or version")
|
|
}
|
|
if l == nil {
|
|
panic("featurefmt: could not register a nil Lister")
|
|
}
|
|
|
|
listersM.Lock()
|
|
defer listersM.Unlock()
|
|
|
|
if _, dup := listers[name]; dup {
|
|
panic("featurefmt: RegisterLister called twice for " + name)
|
|
}
|
|
|
|
listers[name] = lister{l, database.NewFeatureDetector(name, version)}
|
|
}
|
|
|
|
// ListFeatures produces the list of Features in an image layer using
|
|
// every registered Lister.
|
|
func ListFeatures(files tarutil.FilesMap, toUse []database.Detector) ([]database.LayerFeature, error) {
|
|
listersM.RLock()
|
|
defer listersM.RUnlock()
|
|
|
|
features := []database.LayerFeature{}
|
|
for _, d := range toUse {
|
|
// Only use the detector with the same type
|
|
if d.DType != database.FeatureDetectorType {
|
|
continue
|
|
}
|
|
|
|
if lister, ok := listers[d.Name]; ok {
|
|
fs, err := lister.ListFeatures(files)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
for _, f := range fs {
|
|
features = append(features, database.LayerFeature{
|
|
Feature: f,
|
|
By: lister.info,
|
|
})
|
|
}
|
|
|
|
} else {
|
|
log.WithField("Name", d).Fatal("unknown feature detector")
|
|
}
|
|
}
|
|
|
|
return features, nil
|
|
}
|
|
|
|
// RequiredFilenames returns all files required by the give extensions. Any
|
|
// extension metadata that has non feature-detector type will be skipped.
|
|
func RequiredFilenames(toUse []database.Detector) (files []string) {
|
|
listersM.RLock()
|
|
defer listersM.RUnlock()
|
|
|
|
for _, d := range toUse {
|
|
if d.DType != database.FeatureDetectorType {
|
|
continue
|
|
}
|
|
|
|
files = append(files, listers[d.Name].RequiredFilenames()...)
|
|
}
|
|
|
|
return
|
|
}
|
|
|
|
// ListListers returns the names of all the registered feature listers.
|
|
func ListListers() []database.Detector {
|
|
r := []database.Detector{}
|
|
for _, d := range listers {
|
|
r = append(r, d.info)
|
|
}
|
|
return r
|
|
}
|
|
|
|
// TestData represents the data used to test an implementation of Lister.
|
|
type TestData struct {
|
|
Files tarutil.FilesMap
|
|
Features []database.Feature
|
|
}
|
|
|
|
// LoadFileForTest can be used in order to obtain the []byte contents of a file
|
|
// that is meant to be used for test data.
|
|
func LoadFileForTest(name string) []byte {
|
|
_, filename, _, _ := runtime.Caller(0)
|
|
d, _ := ioutil.ReadFile(filepath.Join(filepath.Dir(filename)) + "/" + name)
|
|
return d
|
|
}
|
|
|
|
// TestLister runs a Lister on each provided instance of TestData and asserts
|
|
// the ouput to be equal to the expected output.
|
|
func TestLister(t *testing.T, l Lister, testData []TestData) {
|
|
for _, td := range testData {
|
|
featureVersions, err := l.ListFeatures(td.Files)
|
|
if assert.Nil(t, err) && assert.Len(t, featureVersions, len(td.Features)) {
|
|
for _, expectedFeature := range td.Features {
|
|
assert.Contains(t, featureVersions, expectedFeature)
|
|
}
|
|
}
|
|
}
|
|
}
|