updater: minimize vulns' lock duration in the NVD metadata fetcher

8 years ago · 1c3daa23b9
parent e38b67a513
commit 1c3daa23b9
1 changed files with 2 additions and 1 deletions
--- a/updater/metadata_fetchers/nvd/nvd.go
+++ b/updater/metadata_fetchers/nvd/nvd.go
@ -105,7 +105,6 @@ func (fetcher *NVDMetadataFetcher) AddMetadata(vulnerability *updater.Vulnerabil

 	if nvdMetadata, ok := fetcher.metadata[vulnerability.Name]; ok {
 		vulnerability.Lock.Lock()
-		defer vulnerability.Lock.Unlock()

 		// Create Metadata map if necessary.
 		if vulnerability.Metadata == nil {
@ -113,6 +112,8 @@ func (fetcher *NVDMetadataFetcher) AddMetadata(vulnerability *updater.Vulnerabil
 		}

 		vulnerability.Metadata[metadataKey] = nvdMetadata
+
+		vulnerability.Lock.Unlock()
 	}

 	return nil