Felix Filozov
984005648a
Fixing typo
2021-02-10 20:10:13 -05:00
Matthijs Roelink
5b03ecb3df
Chapter 4: put period outside of quote marks.
2021-02-08 15:12:06 +01:00
rating89us
4971598b5a
glossary: add passphrase entry
2021-02-08 01:47:23 +01:00
jerzybrzoska
b56735ae9c
ch08.asciidoc I specified where UTXO pool is stored in Bitcoin Core to avoid confusion
...
When came across this paragraph I assumed, thinking "some [other than Bitcoin Core] implementations of the bitcoin client" that Bitcoin Core does not store its UTXO pool anywhere. I did [some research] (https://bitcoin.stackexchange.com/questions/102267/where-in-bitcoin-are-mempool-and-utxo-pools-written ) and it turns out that it does. Providing
such a detail to the readers would help avoid unnecessary confusion.
2021-02-05 16:18:13 +01:00
jerzybrzoska
e0af335152
ch08.asciidoc: Implementation status of BIP-150 and BIP-151 (
...
In fact, [BIP-151](https://github.com/bitcoin/bips ) was withdrawn.
2021-02-05 10:52:45 +01:00
rating89us
eb57ec48a0
ch12: transaction -> transactions
2021-01-31 18:22:49 +01:00
rating89us
5a999ae452
ch06: that -> each
2021-01-31 16:27:36 +01:00
rating89us
d4fa3e590a
ch06: extracted -> extracts (parallelism)
2021-01-31 16:17:08 +01:00
jerzybrzoska
dc290d7b87
"verack message" instead of "verack"
...
The reader was not introduced to the term verack earlier - 'verack' appears only once in this chapter. Thus, "verack message" seems more readable.
2021-01-30 16:14:37 +01:00
rating89us
2feb6ac3c3
ch06: a -> this
2021-01-26 08:56:45 +01:00
rating89us
5ecbf39068
ch06: explaining that the change "gift" goes to the miner
2021-01-24 23:58:15 +01:00
rating89us
bbc3572fdc
ch04: add . to end sentence
2021-01-23 18:51:10 +01:00
rating89us
71666cbb54
ch10: replace - by – in Total Fees equation
2021-01-23 03:59:50 +01:00
rating89us
39d0111fe2
glossary: start a new sentence in"P2SH address"
2021-01-22 14:19:29 +01:00
rating89us
eef7d4308b
ch04: sentence is about vanity pool, not pool in general
2021-01-22 00:21:48 +01:00
rating89us
d06e7c54bf
glossary: BIP32 -> BIP-32
2021-01-21 09:21:47 +01:00
rating89us
ab67789c98
ch08: delete extra space before "These two BIPs"
2021-01-21 08:55:00 +01:00
Sandro Conforto
442f6f74e9
ch06: Typo fixes
...
Fix a minor punctuation typo
2021-01-20 21:35:52 +01:00
rating89us
2da27d33c0
ch08: outputs -> output
2021-01-20 20:57:14 +01:00
Andreas M. Antonopoulos
e3695afbf6
Merge pull request #742 from syncom/syncom/ch07-2-of-5-multisig
...
ch07: 2-of-5 instead of 2-of-3 for Mohammed's example
2021-01-19 11:41:58 -06:00
Andreas M. Antonopoulos
bf56c59a85
Merge pull request #746 from jerzybrzoska/patch-3
...
ch.02: Let us not be too assuming about the gender of "each miner"
2021-01-19 11:20:38 -06:00
Hennadii Stepanov
5d50a93ee6
ch10: Align target description with the actual implementation
...
See: 43f3ada27b/src/pow.cpp (L86-L88)
2021-01-19 15:10:02 +02:00
jerzybrzoska
65dd6b8be0
ch.02: Let us not be too assuming about the gender of "each miner"
...
It is too assuming to suppose that the gender of "each miner" is masculine. Hence I propose to use [singular they](https://en.wikipedia.org/wiki/Singular_they ). More on singular they [here](https://www.grammarly.com/blog/use-the-singular-they/ ).
'He' was substituted with 'they' only when it refers to "each miner", i.e. miners in general, and not when it refers to Jing. In the latter case I have left he unchanged.
2021-01-19 13:05:10 +01:00
Ning Shang
7284634837
Nit: exponentially -> significantly
...
In the dice rolling example, because there are only two dice, the phrase 'exponentially more' could cause confusion. It feels better to be a bit handwavy here and just say 'significantly more'.
2021-01-18 20:51:21 -08:00
Ning Shang
c942d694b6
ch07: Typo fixes
...
Fix minor typos related to 'equal to' and 'less/greater than'.
2021-01-18 20:34:24 -08:00
Ning Shang
06f1a947e9
chp04: xref <<vanity_minor_code>> seems better for note on std:random_device
...
Because 'std::random_device' appears in xref vanity_miner_code as opposed to xref vanity_miner_run, it feels more appropriate to use the former in this note.
2021-01-18 20:25:31 -08:00
Ning Shang
555be41b2b
ch07: 2-of-5 instead of 2-of-3 for Mohammed's example
...
The example is a 2-of-5 multisig, according to the Pay-to-Script-Hash example description earlier, and the P2SH example a few lines below.
2021-01-18 20:00:19 -08:00
marco zandonadi
57f0d77d40
Update ch03.asciidoc
...
Indefinite article "a" should precede a noun starting with a consonant
2021-01-18 19:40:45 -08:00
rating89us
f467afe028
ch08: delete extra space
2021-01-18 20:43:05 +01:00
Andreas M. Antonopoulos
b926626c1a
Merge pull request #739 from hebasto/210118-dns
...
ch08: Update number of DNS seeds
2021-01-18 09:08:42 -06:00
Hennadii Stepanov
b5a7b5df3e
ch08: Update number of DNS seeds
...
There are 9 seeds since 0.21: https://github.com/bitcoin/bitcoin/blob/0.21/src/chainparams.cpp#L121-L129
And there were 8 seeds since v0.18: https://github.com/bitcoin/bitcoin/blob/0.18/src/chainparams.cpp#L123-L130
2021-01-18 16:52:48 +02:00
Andreas M. Antonopoulos
d1e61889bb
Merge pull request #738 from rating89us/patch-2
...
ch10: make it clear that we talk about hard fork in bitcoin
2021-01-17 09:40:43 -06:00
rating89us
1d58378edf
ch10: make it clear that hard fork is in bitcoin
2021-01-16 21:06:43 +01:00
rating89us
21597f5cf9
ch01: add space after comma and before i.e.
2021-01-15 17:23:43 +01:00
Andreas M. Antonopoulos
0eb5d5eb30
Merge pull request #733 from hebasto/210113-trap
...
ch04: Fix mathematical terms
2021-01-15 06:46:52 -06:00
Hennadii Stepanov
a8c672ffb5
ch04: Fix mathematical terms
...
1. EC multiplication is a "one-way" function, not a "trapdoor" one.
There is no information that makes reverse function easy.
See:
- https://en.wikipedia.org/wiki/Trapdoor_function
- https://en.wikipedia.org/wiki/One-way_function
2. The "discrete logarithm" is more usual term for the reverse operation
for EC multiplication.
2021-01-15 09:23:51 +02:00
Andreas M. Antonopoulos
387e9b1a31
Merge pull request #735 from jerzybrzoska/patch-1
...
Choice of words: possible but pointless (introduction)
2021-01-14 19:59:00 -06:00
Andreas M. Antonopoulos
ca5d0e6485
Merge pull request #731 from rating89us/patch-9
...
ch02: better wording of transaction outputs explanation
2021-01-14 19:53:33 -06:00
Andreas M. Antonopoulos
784351ad69
Merge pull request #708 from rating89us/patch-5
...
ch10: delete 'no longer'; clarify 'forward' word
2021-01-14 19:34:49 -06:00
Andreas M. Antonopoulos
5d923833a4
Merge pull request #707 from rating89us/patch-4
...
ch10: follows -> follow
2021-01-14 19:34:11 -06:00
Andreas M. Antonopoulos
c7b30db76d
Merge pull request #706 from rating89us/patch-3
...
ch10: add "'s input"
2021-01-14 19:33:26 -06:00
Andreas M. Antonopoulos
8393fa275d
Merge pull request #705 from rating89us/patch-2
...
ch10: paralellism (the...the)
2021-01-14 19:32:39 -06:00
Andreas M. Antonopoulos
71b4e52dcb
Merge pull request #704 from rating89us/patch-1
...
ch10: candidate node -> candidate block
2021-01-14 19:32:04 -06:00
Andreas M. Antonopoulos
3a76f89a46
Merge pull request #700 from satsie/fix-ch10-typo
...
Fix Minor Typo in Chapter 10
2021-01-14 19:31:41 -06:00
Andreas M. Antonopoulos
86d59b0045
Merge pull request #699 from Xekyo/transactionSizes
...
Correct transaction costs in segwit example
2021-01-14 19:30:55 -06:00
Andreas M. Antonopoulos
22a09e0658
Merge pull request #736 from jerzybrzoska/patch-2
...
450 MiB is now the default cache size (ch. 3)
2021-01-14 19:28:50 -06:00
Andreas M. Antonopoulos
43faf7e7a4
Merge pull request #734 from hebasto/210113-hash
...
ch04: Fix terms of ScriptSig
2021-01-14 19:28:27 -06:00
jerzybrzoska
39118cdd21
450 MiB is now the default cache size
...
The default cache size is now 450 MiB on the most recent release (0.20.1)
2021-01-14 12:14:55 +01:00
jerzybrzoska
ccc684d19a
Wording: possible but pointless (introduction)
...
It is possible to make a specific recommendation but it would be rather futile to do so.
2021-01-14 10:51:50 +01:00
Hennadii Stepanov
3d34e80ef5
ch04: Fix terms of ScriptSig
...
For P2PKH outputs the ScriptSig contains a public key, but not its hash.
2021-01-14 02:08:19 +02:00