1
0
mirror of https://github.com/bitcoinbook/bitcoinbook synced 2024-12-24 15:38:08 +00:00
Commit Graph

3806 Commits

Author SHA1 Message Date
Will Binns
9f10eb6259
Merge pull request #794 from rating89us/patch-33
ch11: fix multisig explanation
2021-02-20 10:11:49 +00:00
Will Binns
03f57404aa
Merge pull request #793 from ogennadi/patch-1
Fix typo
2021-02-20 10:09:27 +00:00
Will Binns
a6ca7173f4
Merge pull request #791 from rating89us/patch-30
ch02: explain that both outputs are in a single tx
2021-02-20 10:04:24 +00:00
Will Binns
15a43b927c
Merge pull request #789 from rating89us/patch-29
ch01: Alice's address -> Alice's wallet
2021-02-20 10:03:16 +00:00
rating89us
388da74024
ch05: keys -> addresses 2021-02-20 02:15:30 +01:00
rating89us
b640698e0f
ch04: paper wallet = private key + address 2021-02-19 01:58:46 +01:00
rating89us
57dba437c5
ch11: fix multisig explanation 2021-02-16 16:41:01 +01:00
Oge Nnadi
8c30f250b4
Fix typo 2021-02-15 12:51:42 -06:00
rating89us
b80ffe0bfe
ch02: explain that both outputs are in a single tx 2021-02-14 18:27:46 +01:00
rating89us
4956c6f6c9
ch01: Alice's address -> Alice's wallet 2021-02-13 02:05:39 +01:00
rating89us
76fa766a09
ch01: wallets -> wallet 2021-02-13 01:23:16 +01:00
rating89us
407fd8180b
ch09: simple -> simplified (SPV) 2021-02-12 22:37:30 +01:00
rating89us
6e2568bdff
ch08: simple -> simplified (SPV) 2021-02-12 22:36:47 +01:00
rating89us
c939ce53cb
ch01: simple -> simplified (SPV) 2021-02-12 22:35:29 +01:00
rating89us
0261f4c086
ch02: simple -> simplified (SPV) 2021-02-12 22:33:41 +01:00
rating89us
a65b9fbcd6
ch04: fix multisig explanation 2021-02-12 15:39:11 +01:00
Felix Filozov
cdcfeb16e8 Fixing typo. 2021-02-10 21:24:29 -05:00
Felix Filozov
c66298c3c5 Added missing word. 2021-02-10 21:21:42 -05:00
Felix Filozov
4ee95ea2a9 Adding missing preposition. 2021-02-10 21:20:03 -05:00
Felix Filozov
71d99e62a2 Adding missing bitcoin amounts 2021-02-10 21:10:37 -05:00
Felix Filozov
9fa9fd891e Changing phrase to a more conventional one. 2021-02-10 21:08:19 -05:00
Felix Filozov
879243bf95 Changing phrase to a more conventional one. 2021-02-10 21:06:17 -05:00
Felix Filozov
e60b823854 Fixing off-by-one dice target, and adding more precision to the outcome.
The minimum target cannot be 2, because you can't throw
a pair of dice and get a value less than 2.
2021-02-10 21:00:20 -05:00
Felix Filozov
f8bd256311 Rewording phrase to be consistent with earlier phrasing 2021-02-10 20:13:33 -05:00
Felix Filozov
984005648a Fixing typo 2021-02-10 20:10:13 -05:00
Matthijs Roelink
5b03ecb3df Chapter 4: put period outside of quote marks. 2021-02-08 15:12:06 +01:00
rating89us
4971598b5a
glossary: add passphrase entry 2021-02-08 01:47:23 +01:00
jerzybrzoska
b56735ae9c
ch08.asciidoc I specified where UTXO pool is stored in Bitcoin Core to avoid confusion
When came across this paragraph I assumed, thinking "some [other than Bitcoin Core] implementations of the bitcoin client" that Bitcoin Core does not store its UTXO pool anywhere. I did [some research] (https://bitcoin.stackexchange.com/questions/102267/where-in-bitcoin-are-mempool-and-utxo-pools-written) and it turns out that it does. Providing 
such a detail to the readers would help avoid unnecessary confusion.
2021-02-05 16:18:13 +01:00
jerzybrzoska
e0af335152
ch08.asciidoc: Implementation status of BIP-150 and BIP-151 (
In fact, [BIP-151](https://github.com/bitcoin/bips) was withdrawn.
2021-02-05 10:52:45 +01:00
rating89us
eb57ec48a0
ch12: transaction -> transactions 2021-01-31 18:22:49 +01:00
rating89us
5a999ae452
ch06: that -> each 2021-01-31 16:27:36 +01:00
rating89us
d4fa3e590a
ch06: extracted -> extracts (parallelism) 2021-01-31 16:17:08 +01:00
jerzybrzoska
dc290d7b87
"verack message" instead of "verack"
The reader was not introduced to the term verack earlier - 'verack' appears only once in this chapter. Thus, "verack message" seems more readable.
2021-01-30 16:14:37 +01:00
rating89us
2feb6ac3c3
ch06: a -> this 2021-01-26 08:56:45 +01:00
rating89us
5ecbf39068
ch06: explaining that the change "gift" goes to the miner 2021-01-24 23:58:15 +01:00
rating89us
bbc3572fdc
ch04: add . to end sentence 2021-01-23 18:51:10 +01:00
rating89us
71666cbb54
ch10: replace - by – in Total Fees equation 2021-01-23 03:59:50 +01:00
rating89us
39d0111fe2
glossary: start a new sentence in"P2SH address" 2021-01-22 14:19:29 +01:00
rating89us
eef7d4308b
ch04: sentence is about vanity pool, not pool in general 2021-01-22 00:21:48 +01:00
rating89us
d06e7c54bf
glossary: BIP32 -> BIP-32 2021-01-21 09:21:47 +01:00
rating89us
ab67789c98
ch08: delete extra space before "These two BIPs" 2021-01-21 08:55:00 +01:00
Sandro Conforto
442f6f74e9 ch06: Typo fixes
Fix a minor punctuation typo
2021-01-20 21:35:52 +01:00
rating89us
2da27d33c0
ch08: outputs -> output 2021-01-20 20:57:14 +01:00
Andreas M. Antonopoulos
e3695afbf6
Merge pull request #742 from syncom/syncom/ch07-2-of-5-multisig
ch07: 2-of-5 instead of 2-of-3 for Mohammed's example
2021-01-19 11:41:58 -06:00
Andreas M. Antonopoulos
bf56c59a85
Merge pull request #746 from jerzybrzoska/patch-3
ch.02: Let us not be too assuming about the gender of "each miner"
2021-01-19 11:20:38 -06:00
Hennadii Stepanov
5d50a93ee6
ch10: Align target description with the actual implementation
See: 43f3ada27b/src/pow.cpp (L86-L88)
2021-01-19 15:10:02 +02:00
jerzybrzoska
65dd6b8be0
ch.02: Let us not be too assuming about the gender of "each miner"
It is too assuming to suppose that the gender of "each miner" is masculine. Hence I propose to use [singular they](https://en.wikipedia.org/wiki/Singular_they). More on singular they [here](https://www.grammarly.com/blog/use-the-singular-they/).
'He' was substituted with 'they' only when it refers to "each miner", i.e. miners in general, and not when it refers to Jing. In the latter case I have left he unchanged.
2021-01-19 13:05:10 +01:00
Ning Shang
7284634837
Nit: exponentially -> significantly
In the dice rolling example, because there are only two dice, the phrase 'exponentially more' could cause confusion. It feels better to be a bit handwavy here and just say 'significantly more'.
2021-01-18 20:51:21 -08:00
Ning Shang
c942d694b6
ch07: Typo fixes
Fix minor typos related to 'equal to' and 'less/greater than'.
2021-01-18 20:34:24 -08:00
Ning Shang
06f1a947e9
chp04: xref <<vanity_minor_code>> seems better for note on std:random_device
Because 'std::random_device' appears in xref vanity_miner_code as opposed to xref vanity_miner_run, it feels more appropriate to use the former in this note.
2021-01-18 20:25:31 -08:00