From 41445c9205ae07fe2bfd694fcf9b3f3d54c9fb82 Mon Sep 17 00:00:00 2001 From: leonarddt05 <139609434+leonarddt05@users.noreply.github.com> Date: Thu, 27 Feb 2025 12:30:59 +0300 Subject: [PATCH] Update CONTRIBUTING.md MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi, I have 2 suggestions for this text: -"copy editors job" → Should be "copy editor's job" (possessive form needed). -"Acknowledgment" → Could be "Acknowledgement". Thanks. --- CONTRIBUTING.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 4d45d9ac..ba5d7cbb 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -24,7 +24,7 @@ Added by: @aantonop ## Contributing with a Pull Request -Please submit only PRs for errors that a non-domain-expert copy editor might miss. Do not submit PRs for typos, grammar and syntax, as those are part of the copy editors job. +Please submit only PRs for errors that a non-domain-expert copy editor might miss. Do not submit PRs for typos, grammar and syntax, as those are part of the copy editor's job. The best way to contribute to this book is by making a pull request: @@ -32,7 +32,7 @@ The best way to contribute to this book is by making a pull request: 2. [Fork](https://github.com/bitcoinbook/bitcoinbook#fork-destination-box) the `bitcoinbook` repository. Work on your fork. 3. Create a new branch on which to make your change, e.g. `git checkout -b my_code_contribution`, or make the change on the `develop` branch. 4. Please do one pull request *per asciidoc file*, to avoid large merges. Edit the asciidoc file where you want to make a change. -5. If you want attribution for your contribution, edit the file `meta/github_contrib.adoc` and add your own name to the list of contributors under the Acknowledgment section. Use your name, or a GitHub username, or a pseudonym. You are responsible for creating an attribution. +5. If you want attribution for your contribution, edit the file `meta/github_contrib.adoc` and add your own name to the list of contributors under the Acknowledgement section. Use your name, or a GitHub username, or a pseudonym. You are responsible for creating an attribution. 6. Commit your change. Include a commit message describing the correction. 7. Submit a pull request against the bitcoinbook repository.