You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Rusty Bird 4f59b3df6f qfile-unpacker: syncfs() to avoid qvm-move-to-vm data loss ... Commit https://github.com/QubesOS/qubes-linux-utils/commit/c1d42f1 -- "qfile-unpacker: do not call fdatasync() at each file" fixing QubesOS/qubes-issues#1257 -- increased the chance of data loss with qvm-move-to-vm: Say it nominally succeeds, and *deletes* the files from the source VM. Soon after, the destination VM or the system could crash, or an external drive hosting ~/QubesIncoming/srcVM could get unplugged by accident, all before the data had really been persisted to disk. But reverting the commit (ignoring the performance issue) wouldn't completely solve this: "Calling fsync() does not necessarily ensure that the entry in the directory containing the file has also reached disk. For that an explicit fsync() on a file descriptor for the directory is also needed." - fsync(2) It gets even worse for "slow symlinks" (whose target is too long to be stored directly in the inode metadata), apparently they can't be synced at all individually. So instead, just call syncfs() once after everything has been unpacked: + Should prevent all data loss (if fs and disk are well behaved) + Allows caching and reordering -> no slowdown with many small files - Blocks until any unrelated writes on the filesystem finish :\		9 years ago
archlinux	archlinux: ensure /usr/sbin is not use to follow archlinux packaging guidelines	9 years ago
core	impconverter: add icon data getters	9 years ago
debian	version 3.1.3	9 years ago
dracut	initramfs: fix swap size	9 years ago
initramfs-tools	debian: introduce qubes-kernel-vm-support package	9 years ago
kernel-modules	kernel-modules: build/install u2mfn module by default	9 years ago
pkgs	archlinux: created build scripts	11 years ago
qmemman	use 64-bit integers for memory sizes to support > 2 TB RAM	9 years ago
qrexec-lib	qfile-unpacker: syncfs() to avoid qvm-move-to-vm data loss	9 years ago
rpm_spec	rpm: disable debuginfo subpackage in qubes-kernel-vm-support	9 years ago
udev	udev: do not use a separate lock for udev block scripts	9 years ago
.gitignore	gitignore	10 years ago
Makefile	debian: introduce qubes-kernel-vm-support package	9 years ago
Makefile.builder	Add VM kernel related files as qubes-core-vm-kernel-support package	9 years ago
version	version 3.1.3	9 years ago