QubesOS/qubes-linux-utils
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

txrx-vchan: guard against invalid buffer sizes from libvchan

Browse Source 
These APIs can now return -1 when invalid indices are detected.
This commit is contained in:
Vincent Penquerc'h 2014-01-20 13:22:49 -05:00 committed by Marek Marczykowski-Górecki
parent b51435c903
commit f7e943f7ec
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
qrexec-lib/txrx-vchan.c
View File

@ -73,12 +73,22 @@ int read_all_vchan_ext(void *buf, int size)
int read_ready_vchan_ext() int read_ready_vchan_ext()
{ {
return libvchan_data_ready(ctrl); int ready = libvchan_data_ready(ctrl);
if (ready < 0) {
fprintf(stderr, "libvchan_data_ready returned invalid size\n");
exit(1);
}
return ready;
} }
int buffer_space_vchan_ext() int buffer_space_vchan_ext()
{ {
return libvchan_buffer_space(ctrl); int space = libvchan_buffer_space(ctrl);
if (space < 0) {
fprintf(stderr, "libvchan_buffer_space returned invalid size\n");
exit(1);
}
return space;
} }
// if the remote domain is destroyed, we get no notification // if the remote domain is destroyed, we get no notification