From 80b4c2ecd5640184c9792f0fdedacefd2af8be0f Mon Sep 17 00:00:00 2001 From: Olivier MEDOC Date: Wed, 8 Jul 2015 11:08:47 +0200 Subject: [PATCH 1/2] archlinux: update to match new dependancies and archlinux /usr/lib guidelines --- Makefile | 6 +++--- archlinux/PKGBUILD | 6 +++--- archlinux/PKGBUILD-qubes-vm-utils.install | 9 ++------- 3 files changed, 8 insertions(+), 13 deletions(-) diff --git a/Makefile b/Makefile index 5b81e05..e889d9a 100644 --- a/Makefile +++ b/Makefile @@ -1,9 +1,9 @@ ifeq ($(shell uname -m),x86_64) -LIBDIR = /usr/lib64 +LIBDIR ?= /usr/lib64 else -LIBDIR = /usr/lib +LIBDIR ?= /usr/lib endif -INCLUDEDIR = /usr/include +INCLUDEDIR ?= /usr/include export LIBDIR INCLUDEDIR diff --git a/archlinux/PKGBUILD b/archlinux/PKGBUILD index f01a957..95bdf5e 100644 --- a/archlinux/PKGBUILD +++ b/archlinux/PKGBUILD @@ -6,14 +6,14 @@ # Maintainer: Olivier Medoc pkgname=qubes-vm-utils pkgver=`cat version` -pkgrel=8 +pkgrel=2 epoch= pkgdesc="Common Linux files for Qubes VM." arch=("x86_64") url="http://qubes-os.org/" license=('GPL') groups=() -depends=(qubes-libvchan) +depends=(qubes-libvchan imagemagick python2-cairo) makedepends=(qubes-libvchan) checkdepends=() optdepends=() @@ -43,7 +43,7 @@ make all package() { -make install DESTDIR=$pkgdir +make install DESTDIR=$pkgdir LIBDIR=/usr/lib } diff --git a/archlinux/PKGBUILD-qubes-vm-utils.install b/archlinux/PKGBUILD-qubes-vm-utils.install index 32d2b77..ef095d7 100644 --- a/archlinux/PKGBUILD-qubes-vm-utils.install +++ b/archlinux/PKGBUILD-qubes-vm-utils.install @@ -2,13 +2,8 @@ ## arg 1: the new package version post_install() { ldconfig - if [ -r /etc/qubes-release ]; then - # dom0 - /bin/systemctl enable qubes-meminfo-writer-dom0.service > /dev/null 2>&1 - else - # VM - /bin/systemctl enable qubes-meminfo-writer.service > /dev/null 2>&1 - fi + /bin/systemctl enable qubes-meminfo-writer-dom0.service > /dev/null 2>&1 + /bin/systemctl enable qubes-meminfo-writer.service > /dev/null 2>&1 } post_upgrade() { From 9ee8281ab7b7f3977cf7dab7e98f10e25fc42118 Mon Sep 17 00:00:00 2001 From: Olivier MEDOC Date: Wed, 8 Jul 2015 14:33:48 +0200 Subject: [PATCH 2/2] archlinux: ensure /usr/sbin is not use to follow archlinux packaging guidelines --- archlinux/PKGBUILD | 2 +- qmemman/Makefile | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/archlinux/PKGBUILD b/archlinux/PKGBUILD index 95bdf5e..e918ec4 100644 --- a/archlinux/PKGBUILD +++ b/archlinux/PKGBUILD @@ -43,7 +43,7 @@ make all package() { -make install DESTDIR=$pkgdir LIBDIR=/usr/lib +make install DESTDIR=$pkgdir LIBDIR=/usr/lib SBINDIR=/usr/bin } diff --git a/qmemman/Makefile b/qmemman/Makefile index 8b17eb3..7273268 100644 --- a/qmemman/Makefile +++ b/qmemman/Makefile @@ -1,6 +1,7 @@ CC=gcc CFLAGS=-Wall -Wextra -Werror -g -O3 all: meminfo-writer +SBINDIR?=/usr/sbin _XENSTORE_H=$(shell ls /usr/include/xenstore.h) ifneq "$(_XENSTORE_H)" "" @@ -10,7 +11,7 @@ endif meminfo-writer: meminfo-writer.o $(CC) -g -o meminfo-writer meminfo-writer.o -lxenstore install: - install -D meminfo-writer $(DESTDIR)/usr/sbin/meminfo-writer + install -D meminfo-writer $(DESTDIR)/$(SBINDIR)/meminfo-writer ifeq (1,${DEBIANBUILD}) install -d $(DESTDIR)/lib/systemd/system/ install -m 0644 qubes-meminfo-writer.service $(DESTDIR)/lib/systemd/system/