You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
76 lines
2.5 KiB
76 lines
2.5 KiB
From 6a9f5a2435d3845b41f32b3768bb1c25bba1be2d Mon Sep 17 00:00:00 2001
|
|
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
|
|
Date: Wed, 1 Apr 2015 17:01:26 -0400
|
|
Subject: [PATCH] xen/pcifront/pciback: Update pciif.h with ->err and ->result
|
|
values.
|
|
|
|
The '->err' should contain only the XEN_PCI_ERR_* type values.
|
|
The '->result' may contain -EXX values or any other value
|
|
that the XEN_PCI_OP_* deems appropiate.
|
|
|
|
As such update the header and also the implementations.
|
|
|
|
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
|
|
|
|
Details in this thread:
|
|
https://patchwork.kernel.org/patch/8258431/
|
|
---
|
|
drivers/pci/xen-pcifront.c | 2 +-
|
|
drivers/xen/xen-pciback/pciback_ops.c | 2 +-
|
|
include/xen/interface/io/pciif.h | 6 ++++--
|
|
3 files changed, 6 insertions(+), 4 deletions(-)
|
|
|
|
diff --git a/drivers/pci/xen-pcifront.c b/drivers/pci/xen-pcifront.c
|
|
index d1b16cf3403f..4d6f2513b104 100644
|
|
--- a/drivers/pci/xen-pcifront.c
|
|
+++ b/drivers/pci/xen-pcifront.c
|
|
@@ -297,7 +297,7 @@ static int pci_frontend_enable_msix(struct pci_dev *dev,
|
|
} else {
|
|
pci_err(dev, "enable msix get err %x\n", err);
|
|
}
|
|
- return err;
|
|
+ return err ? -EINVAL : 0;
|
|
}
|
|
|
|
static void pci_frontend_disable_msix(struct pci_dev *dev)
|
|
diff --git a/drivers/xen/xen-pciback/pciback_ops.c b/drivers/xen/xen-pciback/pciback_ops.c
|
|
index 787966f44589..0574c9121124 100644
|
|
--- a/drivers/xen/xen-pciback/pciback_ops.c
|
|
+++ b/drivers/xen/xen-pciback/pciback_ops.c
|
|
@@ -266,7 +266,7 @@ int xen_pcibk_enable_msix(struct xen_pcibk_device *pdev,
|
|
if (dev_data)
|
|
dev_data->ack_intr = 0;
|
|
|
|
- return result > 0 ? 0 : result;
|
|
+ return result >= 0 ? 0 : XEN_PCI_ERR_op_failed;
|
|
}
|
|
|
|
static
|
|
diff --git a/include/xen/interface/io/pciif.h b/include/xen/interface/io/pciif.h
|
|
index d9922ae36eb5..c8b674fd2455 100644
|
|
--- a/include/xen/interface/io/pciif.h
|
|
+++ b/include/xen/interface/io/pciif.h
|
|
@@ -70,7 +70,7 @@ struct xen_pci_op {
|
|
/* IN: what action to perform: XEN_PCI_OP_* */
|
|
uint32_t cmd;
|
|
|
|
- /* OUT: will contain an error number (if any) from errno.h */
|
|
+ /* OUT: will contain an XEN_PCI_ERR_* number. */
|
|
int32_t err;
|
|
|
|
/* IN: which device to touch */
|
|
@@ -82,7 +82,9 @@ struct xen_pci_op {
|
|
int32_t offset;
|
|
int32_t size;
|
|
|
|
- /* IN/OUT: Contains the result after a READ or the value to WRITE */
|
|
+ /* IN/OUT: Contains the result after a READ or the value to WRITE.
|
|
+ * If the err does not have XEN_PCI_ERR_success, depending on
|
|
+ * XEN_PCI_OP_* might have the errno value. */
|
|
uint32_t value;
|
|
/* IN: Contains extra infor for this operation */
|
|
uint32_t info;
|
|
--
|
|
2.21.0
|
|
|