fa4d491f88
We have been doing this filtering already, but some paths have likely changed and the filter was no longer effective. So add two new filter strings: "_intf.storage.ksdata" "_intf.data" After adding these two I was no longer able to find the plaintext password anywhere in the traceback after manually triggering a crash with: kill -USR1 `cat /var/run/anaconda.pid` Resolves: rhbz#1519895
371 lines
15 KiB
Python
371 lines
15 KiB
Python
#
|
|
# exception.py - general exception formatting and saving
|
|
#
|
|
# Copyright (C) 2000-2013 Red Hat, Inc.
|
|
# All rights reserved.
|
|
#
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 2 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
#
|
|
from meh import Config
|
|
from meh.handler import ExceptionHandler
|
|
from meh.dump import ReverseExceptionDump
|
|
from pyanaconda import iutil, kickstart
|
|
import sys
|
|
import os
|
|
import shutil
|
|
import time
|
|
import re
|
|
import errno
|
|
import glob
|
|
import traceback
|
|
import blivet.errors
|
|
from pyanaconda.errors import CmdlineError
|
|
from pyanaconda.ui.communication import hubQ
|
|
from pyanaconda.constants import THREAD_EXCEPTION_HANDLING_TEST, IPMI_FAILED
|
|
from pyanaconda.threads import threadMgr
|
|
from pyanaconda.i18n import _
|
|
from pyanaconda import flags
|
|
from pyanaconda import startup_utils
|
|
|
|
import gi
|
|
gi.require_version("GLib", "2.0")
|
|
|
|
from gi.repository import GLib
|
|
|
|
import logging
|
|
log = logging.getLogger("anaconda")
|
|
|
|
class AnacondaReverseExceptionDump(ReverseExceptionDump):
|
|
|
|
@property
|
|
def desc(self):
|
|
"""
|
|
When traceback will be part of the exception message split the
|
|
description from traceback. Description is used in name of the
|
|
bug in Bugzilla.
|
|
This is useful when saving exception in exception handler and
|
|
raising this exception elsewhere (subprocess exception).
|
|
|
|
:return: Exception description (bug name)
|
|
:rtype: str
|
|
"""
|
|
if self.type and self.value:
|
|
parsed_exc = traceback.format_exception_only(self.type, self.value)[0].split("\nTraceback")
|
|
description = parsed_exc[0]
|
|
# TODO: remove when fixed (#1277422)
|
|
# Use only first line of description (because of libreport bug - reported)
|
|
description = description.split("\n")[0]
|
|
return description.strip()
|
|
else:
|
|
return ""
|
|
|
|
class AnacondaExceptionHandler(ExceptionHandler):
|
|
|
|
def __init__(self, confObj, intfClass, exnClass, tty_num, gui_lock, interactive):
|
|
"""
|
|
:see: python-meh's ExceptionHandler
|
|
:param tty_num: the number of tty the interface is running on
|
|
|
|
"""
|
|
|
|
ExceptionHandler.__init__(self, confObj, intfClass, exnClass)
|
|
self._gui_lock = gui_lock
|
|
self._intf_tty_num = tty_num
|
|
self._interactive = interactive
|
|
|
|
def _main_loop_handleException(self, dump_info):
|
|
"""
|
|
Helper method with one argument only so that it can be registered
|
|
with GLib.idle_add() to run on idle or called from a handler.
|
|
|
|
:type dump_info: an instance of the meh.DumpInfo class
|
|
|
|
"""
|
|
|
|
ty = dump_info.exc_info.type
|
|
value = dump_info.exc_info.value
|
|
|
|
if (issubclass(ty, blivet.errors.StorageError) and value.hardware_fault) \
|
|
or (issubclass(ty, OSError) and value.errno == errno.EIO):
|
|
# hardware fault or '[Errno 5] Input/Output error'
|
|
hw_error_msg = _("The installation was stopped due to what "
|
|
"seems to be a problem with your hardware. "
|
|
"The exact error message is:\n\n%s.\n\n "
|
|
"The installer will now terminate.") % str(value)
|
|
self.intf.messageWindow(_("Hardware error occurred"), hw_error_msg)
|
|
sys.exit(0)
|
|
elif isinstance(value, blivet.errors.UnusableConfigurationError):
|
|
sys.exit(0)
|
|
else:
|
|
super(AnacondaExceptionHandler, self).handleException(dump_info)
|
|
return False
|
|
|
|
def handleException(self, dump_info):
|
|
"""
|
|
Our own handleException method doing some additional stuff before
|
|
calling the original python-meh's one.
|
|
|
|
:type dump_info: an instance of the meh.DumpInfo class
|
|
:see: python-meh's ExceptionHandler.handleException
|
|
|
|
"""
|
|
|
|
log.debug("running handleException")
|
|
exception_lines = traceback.format_exception(*dump_info.exc_info)
|
|
log.critical("\n".join(exception_lines))
|
|
|
|
ty = dump_info.exc_info.type
|
|
value = dump_info.exc_info.value
|
|
|
|
try:
|
|
gi.require_version("Gtk", "3.0")
|
|
|
|
from gi.repository import Gtk
|
|
|
|
# XXX: Gtk stopped raising RuntimeError if it fails to
|
|
# initialize. Horay! But will it stay like this? Let's be
|
|
# cautious and raise the exception on our own to work in both
|
|
# cases
|
|
initialized = Gtk.init_check(None)[0]
|
|
if not initialized:
|
|
raise RuntimeError()
|
|
|
|
# Attempt to grab the GUI initializing lock, do not block
|
|
if not self._gui_lock.acquire(False):
|
|
# the graphical interface is running, don't crash it by
|
|
# running another one potentially from a different thread
|
|
log.debug("Gtk running, queuing exception handler to the "
|
|
"main loop")
|
|
GLib.idle_add(self._main_loop_handleException, dump_info)
|
|
else:
|
|
log.debug("Gtk not running, starting Gtk and running "
|
|
"exception handler in it")
|
|
self._main_loop_handleException(dump_info)
|
|
|
|
except (RuntimeError, ImportError, ValueError):
|
|
log.debug("Gtk cannot be initialized")
|
|
# X not running (Gtk cannot be initialized)
|
|
if threadMgr.in_main_thread():
|
|
log.debug("In the main thread, running exception handler")
|
|
if issubclass(ty, CmdlineError) or not self._interactive:
|
|
if issubclass(ty, CmdlineError):
|
|
cmdline_error_msg = _("\nThe installation was stopped due to "
|
|
"incomplete spokes detected while running "
|
|
"in non-interactive cmdline mode. Since there "
|
|
"cannot be any questions in cmdline mode, "
|
|
"edit your kickstart file and retry "
|
|
"installation.\nThe exact error message is: "
|
|
"\n\n%s.\n\nThe installer will now terminate.") % str(value)
|
|
else:
|
|
cmdline_error_msg = _("\nRunning in cmdline mode, no interactive debugging "
|
|
"allowed.\nThe exact error message is: "
|
|
"\n\n%s.\n\nThe installer will now terminate.") % str(value)
|
|
|
|
# since there is no UI in cmdline mode and it is completely
|
|
# non-interactive, we can't show a message window asking the user
|
|
# to acknowledge the error; instead, print the error out and sleep
|
|
# for a few seconds before exiting the installer
|
|
print(cmdline_error_msg)
|
|
time.sleep(10)
|
|
sys.exit(1)
|
|
else:
|
|
print("\nAn unknown error has occured, look at the "
|
|
"/tmp/anaconda-tb* file(s) for more details")
|
|
# in the main thread, run exception handler
|
|
self._main_loop_handleException(dump_info)
|
|
else:
|
|
log.debug("In a non-main thread, sending a message with "
|
|
"exception data")
|
|
# not in the main thread, just send message with exception
|
|
# data and let message handler run the exception handler in
|
|
# the main thread
|
|
exc_info = dump_info.exc_info
|
|
hubQ.send_exception((exc_info.type,
|
|
exc_info.value,
|
|
exc_info.stack))
|
|
|
|
def postWriteHook(self, dump_info):
|
|
anaconda = dump_info.object
|
|
|
|
# See if there is a /root present in the root path and put exception there as well
|
|
if os.access(iutil.getSysroot() + "/root", os.X_OK):
|
|
try:
|
|
dest = iutil.getSysroot() + "/root/%s" % os.path.basename(self.exnFile)
|
|
shutil.copyfile(self.exnFile, dest)
|
|
except (shutil.Error, IOError):
|
|
log.error("Failed to copy %s to %s/root", self.exnFile, iutil.getSysroot())
|
|
|
|
# run kickstart traceback scripts (if necessary)
|
|
try:
|
|
iutil.runOnErrorScripts(anaconda.ksdata.scripts)
|
|
kickstart.runTracebackScripts(anaconda.ksdata.scripts)
|
|
# pylint: disable=bare-except
|
|
except:
|
|
pass
|
|
|
|
iutil.ipmi_report(IPMI_FAILED)
|
|
|
|
def runDebug(self, exc_info):
|
|
if flags.can_touch_runtime_system("switch console") \
|
|
and self._intf_tty_num != 1:
|
|
iutil.vtActivate(1)
|
|
|
|
os.open("/dev/console", os.O_RDWR) # reclaim stdin
|
|
os.dup2(0, 1) # reclaim stdout
|
|
os.dup2(0, 2) # reclaim stderr
|
|
# ^
|
|
# |
|
|
# +------ dup2 is magic, I tells ya!
|
|
|
|
# bring back the echo
|
|
import termios
|
|
si = sys.stdin.fileno()
|
|
attr = termios.tcgetattr(si)
|
|
attr[3] = attr[3] & termios.ECHO
|
|
termios.tcsetattr(si, termios.TCSADRAIN, attr)
|
|
|
|
print("\nEntering debugger...")
|
|
print("Use 'continue' command to quit the debugger and get back to "\
|
|
"the main window")
|
|
import pdb
|
|
pdb.post_mortem(exc_info.stack)
|
|
|
|
if flags.can_touch_runtime_system("switch console") \
|
|
and self._intf_tty_num != 1:
|
|
iutil.vtActivate(self._intf_tty_num)
|
|
|
|
def initExceptionHandling(anaconda):
|
|
fileList = ["/tmp/anaconda.log", "/tmp/packaging.log",
|
|
"/tmp/program.log", "/tmp/storage.log", "/tmp/ifcfg.log",
|
|
"/tmp/dnf.librepo.log", "/tmp/hawkey.log",
|
|
"/tmp/lvm.log", iutil.getSysroot() + "/root/install.log",
|
|
"/proc/cmdline"]
|
|
|
|
if os.path.exists("/tmp/syslog"):
|
|
fileList.extend(["/tmp/syslog"])
|
|
|
|
if anaconda.opts and anaconda.opts.ksfile:
|
|
fileList.extend([anaconda.opts.ksfile])
|
|
|
|
conf = Config(programName="anaconda",
|
|
programVersion=startup_utils.get_anaconda_version_string(),
|
|
programArch=os.uname()[4],
|
|
attrSkipList=["_intf._actions",
|
|
"_intf._currentAction._xklwrapper",
|
|
"_intf._currentAction._spokes[\"KeyboardSpoke\"]._xkl_wrapper",
|
|
"_intf._currentAction._storage_playground",
|
|
"_intf._currentAction._spokes[\"CustomPartitioningSpoke\"]._storage_playground",
|
|
"_intf._currentAction.language.translations",
|
|
"_intf._currentAction.language.locales",
|
|
"_intf._currentAction._spokes[\"PasswordSpoke\"]._oldweak",
|
|
"_intf._currentAction._spokes[\"PasswordSpoke\"]._password",
|
|
"_intf._currentAction._spokes[\"UserSpoke\"]._password",
|
|
"_intf._currentAction._spokes[\"UserSpoke\"]._oldweak",
|
|
"_intf.storage.bootloader.password",
|
|
"_intf.storage.data",
|
|
"_intf.storage.ksdata",
|
|
"_intf.storage.encryption_passphrase",
|
|
"_intf.data",
|
|
"_bootloader.encrypted_password",
|
|
"_bootloader.password",
|
|
"payload._groups"],
|
|
localSkipList=["passphrase", "password", "_oldweak", "_password", "try_passphrase"],
|
|
fileList=fileList)
|
|
|
|
conf.register_callback("lsblk_output", lsblk_callback, attchmnt_only=True)
|
|
conf.register_callback("nmcli_dev_list", nmcli_dev_list_callback,
|
|
attchmnt_only=True)
|
|
conf.register_callback("type", lambda: "anaconda", attchmnt_only=True)
|
|
conf.register_callback("addons", list_addons_callback, attchmnt_only=False)
|
|
|
|
if "/tmp/syslog" not in fileList:
|
|
# no syslog, grab output from journalctl and put it also to the
|
|
# anaconda-tb file
|
|
conf.register_callback("journalctl", journalctl_callback, attchmnt_only=False)
|
|
|
|
interactive = not anaconda.displayMode == 'c'
|
|
handler = AnacondaExceptionHandler(conf, anaconda.intf.meh_interface,
|
|
AnacondaReverseExceptionDump, anaconda.intf.tty_num,
|
|
anaconda.gui_initialized, interactive)
|
|
handler.install(anaconda)
|
|
|
|
return conf
|
|
|
|
def lsblk_callback():
|
|
"""Callback to get info about block devices."""
|
|
|
|
return iutil.execWithCapture("lsblk", ["--perms", "--fs", "--bytes"])
|
|
|
|
def nmcli_dev_list_callback():
|
|
"""Callback to get info about network devices."""
|
|
|
|
return iutil.execWithCapture("nmcli", ["device", "show"])
|
|
|
|
def journalctl_callback():
|
|
"""Callback to get logs from journalctl."""
|
|
|
|
# regex to filter log messages from anaconda's process (we have that in our
|
|
# logs)
|
|
anaconda_log_line = re.compile(r"\[%d\]:" % os.getpid())
|
|
ret = ""
|
|
for line in iutil.execReadlines("journalctl", ["-b"]):
|
|
if anaconda_log_line.search(line) is None:
|
|
# not an anaconda's message
|
|
ret += line + "\n"
|
|
|
|
return ret
|
|
|
|
def list_addons_callback():
|
|
"""
|
|
Callback to get info about the addons potentially affecting Anaconda's
|
|
behaviour.
|
|
|
|
"""
|
|
|
|
# list available addons and take their package names
|
|
addon_pkgs = glob.glob("/usr/share/anaconda/addons/*")
|
|
return ", ".join(addon.rsplit("/", 1)[1] for addon in addon_pkgs)
|
|
|
|
def test_exception_handling():
|
|
"""
|
|
Function that can be used for testing exception handling in anaconda. It
|
|
tries to prepare a worst case scenario designed from bugs seen so far.
|
|
|
|
"""
|
|
|
|
# XXX: this is a huge hack, but probably the only way, how we can get
|
|
# "unique" stack and thus unique hash and new bugreport
|
|
def raise_exception(msg, non_ascii):
|
|
timestamp = str(time.time()).split(".", 1)[0]
|
|
|
|
code = """
|
|
def f%s(msg, non_ascii):
|
|
raise RuntimeError(msg)
|
|
|
|
f%s(msg, non_ascii)
|
|
""" % (timestamp, timestamp)
|
|
|
|
eval(compile(code, "str_eval", "exec"))
|
|
|
|
# test non-ascii characters dumping
|
|
non_ascii = u'\u0159'
|
|
|
|
msg = "NOTABUG: testing exception handling"
|
|
|
|
# raise exception from a separate thread
|
|
from pyanaconda.threads import AnacondaThread
|
|
threadMgr.add(AnacondaThread(name=THREAD_EXCEPTION_HANDLING_TEST,
|
|
target=raise_exception,
|
|
args=(msg, non_ascii)))
|