Commit Graph

19 Commits

Author SHA1 Message Date
Vincent Penquerc'h
771be64912 qrexec-daemon: fix read underflow when the last fd goes
If no remaining fd is alive in the list, the loop breaks when i
is negative, but by then clients[-1] would have been dereferenced.
2014-01-06 17:54:47 +01:00
Vincent Penquerc'h
bac950c5ce qrexec-daemon: check we really did drop root privileges
and drop group privileges too while we're at it
2014-01-06 17:54:46 +01:00
Vincent Penquerc'h
5e4e1fe6ac qrexec-daemon: fix pathological break-out-of-wait-loop
If the timeout is 1, attempting to retry would not actually retry,
since i would be incremented just after being reset to 0, and would
thus break out of the loop.
2014-01-06 17:54:46 +01:00
Vincent Penquerc'h
e88faee9dd qrexec-daemon: reject negative timeouts 2014-01-06 17:54:46 +01:00
Vincent Penquerc'h
259d7aaf78 qrexec-daemon: use fully qualified path to kdialog/zenity 2014-01-06 17:54:46 +01:00
Vincent Penquerc'h
67f27bd94f qrexec-daemon: make children_count volatile
It's decremented in a signal handler
2014-01-06 17:54:46 +01:00
Vincent Penquerc'h
97c7c97420 qrexec-policy: warn if some data is ignored
Something like vm1 vm2 allow, user=foo would be 4 items,
and the user part would be ignored by the parser.
It might or might not be better to error out instead of
just warning, though...
2014-01-06 17:54:46 +01:00
Marek Marczykowski-Górecki
05390894be Qrexec: log allowed RPC calls 2013-10-27 19:23:09 +01:00
Marek Marczykowski-Górecki
0ab5a89895 Minor whitespace fix 2013-10-27 19:22:47 +01:00
Marek Marczykowski-Górecki
ce971eaa54 qrexec: don't wait indefinitely if the daemon startup failed
Count started children and if the last one exits before getting SIGUSR1
(confirmation of successful daemon startup) report failure.
2013-10-27 17:19:43 +01:00
Marek Marczykowski-Górecki
19e7663928 qrexec-daemon: optionally don't wait for connection to the VM
Will be used to keep qrexec-daemon running in the background even if no
qrexec-agent installed (yet). Specifically to give the VM a chance to
inform about just installed agent.
2013-10-23 05:43:37 +02:00
Marek Marczykowski-Górecki
72b528ddd1 Revert "rpm: fix policy/qubes.SyncAppMenus name"
This reverts commit de087e9b8d.
Mangled two changes together.
2013-10-23 05:39:46 +02:00
Marek Marczykowski-Górecki
de087e9b8d rpm: fix policy/qubes.SyncAppMenus name 2013-10-23 00:25:50 +02:00
Marek Marczykowski-Górecki
28aa4d992f qrexec: display VM name in connect timeout message (#723)
Now it is possible, as we have domain name from cmdline.
2013-10-18 03:47:58 +02:00
Marek Marczykowski-Górecki
c92bc0a05c qrexec: use VM name in log filename 2013-10-18 02:27:46 +02:00
Marek Marczykowski
cf8959dbfe qrexec: get domain name from cmdline
libvchan_get_domain_name will be removed
2013-10-18 02:26:54 +02:00
Marek Marczykowski-Górecki
c95cd3a054 qrexec: validate target domain (#743) 2013-08-15 00:01:56 +02:00
Marek Marczykowski-Górecki
aedd97bb3a qrexec: minor formating fix 2013-08-15 00:01:41 +02:00
Marek Marczykowski
158bfff3cf Add qrexec back, use qubes-utils libraries for common code 2013-03-20 06:24:17 +01:00