Commit Graph

26 Commits

Author SHA1 Message Date
Bahtiar `kalkin-` Gadimov
6590931fcd Make appmenu paths properties and not config attrs
This fixes a circular dependencies where get_attrs_config() in QubesVm is
executed, before the self.storage is initialised. See also
https://github.com/QubesOS/qubes-core-admin/pull/6#discussion-diff-45008401
2015-11-22 12:31:16 +01:00
Bahtiar `kalkin-` Gadimov
4d94309087 Remove unused imports from qubes-core-appmenus 2015-11-17 21:28:26 +01:00
Marek Marczykowski-Górecki
4d3a7ad5c6
appmenus: remove entries from AppVMs menus when removed from template
Fixes QubesOS/qubes-issues#1411
2015-11-13 02:48:15 +01:00
Marek Marczykowski-Górecki
4e1f6b5bd5 core: use vm.absolute_path to parse paths in qubes.xml
This makes easier to handle some corner cases.

qubesos/qubes-issues#1124
Reported by @doncohen, thanks @wyory for providing more details.
2015-09-04 01:57:59 +02:00
Marek Marczykowski-Górecki
ccd8021af9 appmenus: do not create appmenus for DispVMs (#1123)
Fixes qubesos/qubes-issues#1123
2015-09-03 01:18:16 +02:00
Marek Marczykowski-Górecki
50eb23d60e appmenus: add missing appicons_cleanup function
Commit f05f214f "appmenus: update icons only when changed" introduced
usage of vm.appicons_cleanup, but that function wasn't implemented. That
caused not generating appmenus at all after template update (old
appmenus was removed, but script crashes before adding the new one).
2015-05-02 23:49:40 +02:00
Marek Marczykowski-Górecki
febac40b05 appmenus: convert eval's to lambda's 2015-05-02 21:09:42 +02:00
Marek Marczykowski-Górecki
59d9dc0307 appmenus: minor code style fixes
Use 'in' instead of has_key, remove unused code.
2015-05-02 21:09:42 +02:00
Marek Marczykowski-Górecki
2a08357fa4 appmenus: script formatting
Wrap long lines, fix whitespaces
2015-05-02 21:09:42 +02:00
Marek Marczykowski-Górecki
f05f214f6c appmenus: update icons only when changed
Do not regenerate all the icons when the source is unchanged.

Also add preliminary code to support the same improvement for .desktop
files, but it requires some more work, especially because KDE does a lot
of caching and we need to force update sometimes (for example when VM
label color has changed).
2015-04-28 12:45:29 +02:00
Marek Marczykowski-Górecki
40178a161e appmenus: mute output when verbose=False 2014-09-18 07:46:00 +02:00
Marek Marczykowski-Górecki
4758fc1781 appmenus: create apps.tempicons directory if missing (#896) 2014-09-09 02:13:08 +02:00
Wojciech Zygmunt Porczyk
0f7730c2e3 appmenus: use new label icons 2014-07-10 16:28:05 +02:00
Wojciech Zygmunt Porczyk
bad449f235 qubes-core-appmenus.py: create/remove appmenus only when attribtute changes
This is part of #827 bug.
2014-05-05 22:26:53 +02:00
Wojciech Zygmunt Porczyk
a9980d6d34 qubes-core-appmenus.py: create/remove appmenus when re/setting internal
This is part of #827 bug.
2014-05-05 16:47:34 +02:00
Marek Marczykowski-Górecki
7afc15dcf0 appmenus: workarounds for non-refreshing icon caches (#751) 2014-04-16 16:59:47 +02:00
Marek Marczykowski-Górecki
aea6b3c1f5 appmenus: fix creating appmenus when no entry is selected 2014-04-14 04:12:00 +02:00
Marek Marczykowski-Górecki
849b8450ce appmenus: include appicons in clone_disk_files hook 2014-02-22 01:25:18 +01:00
Marek Marczykowski-Górecki
168b182a7d appmenus: handle the case when template don't have appicons yet 2014-02-13 10:42:30 +01:00
Wojciech Zygmunt Porczyk
d8145677d6 appicons: fix directory creation and removal (when missing) 2014-01-30 23:11:56 +01:00
Wojciech Porczyk
92f6e29f43
appmenus: appicons integration 2014-01-14 16:03:15 +01:00
Marek Marczykowski-Górecki
190d52b6fb appmenus: add QubesVm.appmenus_recreate method 2013-12-04 03:03:48 +01:00
Marek Marczykowski-Górecki
9313be30ff appmenus: fix the code for creating standalone VMs
... without source template. Especially HVM and HVM template.
2013-11-25 07:19:20 +01:00
Marek Marczykowski-Górecki
4893b28751 appmenus: fix handling template VMs and HVMs
Adding separate hook for QubesTemplateVm doesn't work - this refers to
the same hook list as in base class. But actually generic hook covers
template case without any change.

Also do not skip adding appmenus for HVM
2013-11-22 03:59:06 +01:00
Marek Marczykowski
40c5379f0b appmenus: fix domain clone
clone_disk_files hook was added twice.
2013-05-25 22:19:58 +02:00
Marek Marczykowski
ad522026d3 Initial commit: appmenus handling code, icons 2013-03-16 18:23:22 +01:00