QubesOS/qubes-core-admin-linux
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

qfile-dom0-unpacker: some error checking

Browse Source
This commit is contained in:
Vincent Penquerc'h 2014-01-12 06:39:58 -05:00 committed by Marek Marczykowski-Górecki
parent fa8ef4b4fc
commit e6a5210d08
1 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
dom0-updates/qfile-dom0-unpacker.c
View File

@ -33,9 +33,15 @@ int prepare_creds_return_uid(const char *username)
} }
setenv("HOME", pwd->pw_dir, 1); setenv("HOME", pwd->pw_dir, 1);
setenv("USER", pwd->pw_name, 1); setenv("USER", pwd->pw_name, 1);
setgid(pwd->pw_gid); if (setgid(pwd->pw_gid) < 0) {
perror("setgid");
exit(1);
}
initgroups(pwd->pw_name, pwd->pw_gid); initgroups(pwd->pw_name, pwd->pw_gid);
setfsuid(pwd->pw_uid); if (setfsuid(pwd->pw_uid) < 0) {
perror("setfsuid");
exit(1);
}
return pwd->pw_uid; return pwd->pw_uid;
} }
@ -69,7 +75,10 @@ int main(int argc, char ** argv)
fprintf(stderr, "Error chroot to %s", incoming_dir); fprintf(stderr, "Error chroot to %s", incoming_dir);
exit(1); exit(1);
} }
setuid(uid); if (setuid(uid) < 0) {
perror("setuid");
exit(1);
}
set_size_limit(bytes_limit, files_limit); set_size_limit(bytes_limit, files_limit);
if (argc > 3 && strcmp(argv[3],"-v")==0) if (argc > 3 && strcmp(argv[3],"-v")==0)
set_verbose(1); set_verbose(1);