From a0a2af3d0f1a11164e08313fa008a56f6b31fdcf Mon Sep 17 00:00:00 2001 From: Galland Date: Wed, 16 Mar 2016 22:38:38 +0100 Subject: [PATCH] Add colon (:) to trusted characters (for "Code::Blocks" appmenu) After installing "codeblocks" app in TemplateVM it doesn't appear in Qubes VM Manager's available app shortcuts. If I run in a Dom0 Terminal: /usr/libexec/qubes-appmenus/qubes-receive-appmenus fedora-23 I get this: "Warning: ignoring key 'Name' of codeblocks.desktop" The "Name" key in that file has value "Code::Blocks" The problem comes from line 168, because of the colons in the app Name. By adding the colon ":" to the std_re used to match valid characters for "Name", the app is correctly parsed and I can add the shortcut to AppVMs (cherry picked from commit 3acfb8e4b3177db0b4a09265b593d05c4b36cedb) Notes from origin: Fixes QubesOS/qubes-issues#1852 --- appmenus-scripts/qubes-receive-appmenus | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/appmenus-scripts/qubes-receive-appmenus b/appmenus-scripts/qubes-receive-appmenus index 6cdfab8..7bbd479 100755 --- a/appmenus-scripts/qubes-receive-appmenus +++ b/appmenus-scripts/qubes-receive-appmenus @@ -44,7 +44,7 @@ appmenus_line_size = 1024 appmenus_line_count = 100000 # regexps for sanitization of retrieved values -std_re = re.compile(r"^[/a-zA-Z0-9.,&()_ -]*$") +std_re = re.compile(r"^[/a-zA-Z0-9.,:&()_ -]*$") fields_regexp = { "Name": std_re, "GenericName": std_re,